Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone editor: Remove more dependencies #2139

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Conversation

JiuqingSong
Copy link
Collaborator

Remove more dependencies to old code to get ready for standalone editor. Including

Entity delimiter related functions

  • getDelimiterFromElement: Create a replacement function isEntityDelimiter in roosterjs-content-model-dom
  • addDelimiters: Create a copy in roosterjs-content-model-dom

Metadata related functions

  • validate: Create a copy in roosterjs-content-model-dom
  • create*Definition: Create a copy in roosterjs-content-model-dom
  • Definition: Create a copy in roosterjs-content-model-types
  • DefinitionType: Create a new type in roosterjs-content-model-types, use string literal type instead of const enum

Other DOM utilities

  • wrap: Create a copy in roosterjs-content-model-dom
  • unwrap: Create a copy in roosterjs-content-model-dom

@JiuqingSong JiuqingSong marked this pull request as ready for review October 16, 2023 16:54
@JiuqingSong JiuqingSong merged commit 573f78a into master Oct 16, 2023
7 checks passed
@JiuqingSong JiuqingSong deleted the u/jisong/listrefactor3 branch October 16, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants