Add Table Borders basic functionality #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiuqingSong
reviewed
Oct 13, 2023
demo/scripts/controls/ribbonButtons/contentModel/tableBorderColorButton.ts
Outdated
Show resolved
Hide resolved
packages-content-model/roosterjs-content-model-editor/lib/publicApi/table/editTable.ts
Outdated
Show resolved
Hide resolved
packages-content-model/roosterjs-content-model-editor/lib/publicTypes/ContentModelEditorCore.ts
Outdated
Show resolved
Hide resolved
demo/scripts/controls/ribbonButtons/contentModel/tableBorderColorButton.ts
Outdated
Show resolved
Hide resolved
…u/acampostams/table-borders-core
…u/acampostams/table-borders-core
JiuqingSong
reviewed
Oct 18, 2023
packages-content-model/roosterjs-content-model-editor/lib/publicTypes/enum/BorderOperations.ts
Outdated
Show resolved
Hide resolved
packages-content-model/roosterjs-content-model-editor/lib/publicApi/table/formatTable.ts
Outdated
Show resolved
Hide resolved
...s-content-model/roosterjs-content-model-editor/lib/publicApi/table/applyTableBorderFormat.ts
Show resolved
Hide resolved
...s-content-model/roosterjs-content-model-editor/lib/publicApi/table/applyTableBorderFormat.ts
Outdated
Show resolved
Hide resolved
...s-content-model/roosterjs-content-model-editor/lib/publicApi/table/applyTableBorderFormat.ts
Outdated
Show resolved
Hide resolved
packages-content-model/roosterjs-content-model-editor/lib/modelApi/table/applyTableFormat.ts
Outdated
Show resolved
Hide resolved
...s-content-model/roosterjs-content-model-editor/lib/publicApi/table/applyTableBorderFormat.ts
Outdated
Show resolved
Hide resolved
…u/acampostams/table-borders-core
…u/acampostams/table-borders-core
Andres-CT98
requested review from
JiuqingSong,
BryanValverdeU,
juliaroldi,
vinguyen12 and
ianeli1
JiuqingSong
reviewed
Oct 18, 2023
...s-content-model/roosterjs-content-model-editor/lib/publicApi/table/applyTableBorderFormat.ts
Show resolved
Hide resolved
JiuqingSong
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implement the ability to modify table borders.
Fix
The apply function takes the cell selection and applies the given operation accordingly. The border needs to be applied to the selected cells as well as adjacent ones (perimeter) which share the same border to ensure format visibility and persistence in situations such as copy.
Storage of the table border format is made as a state in MainPaneBaseState.
Any border modification will result in the whole cell being marked as modified.
Warnings and implications