Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone editor: Remove dependency to DOM utils #2151

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

JiuqingSong
Copy link
Collaborator

In this change I remove the following dependencies:

  • findClosestElementAncestor: Use Element.closest instead
  • matchesSelector: Use Element.matches instead
  • Browser: Add a Environment object in EditorCore and for now it only has isMac property
  • isModifierKey: Create a copy
  • isCharacterValue: Create a copy
  • readFile: Create a copy
  • getMetadata: Use existing API updateImageMetadata instead
  • contains: Use Element.contains instead
  • parseColor: Create a copy
  • createElement: Use document.createElement instead

@JiuqingSong JiuqingSong marked this pull request as ready for review October 17, 2023 01:13
@JiuqingSong JiuqingSong merged commit a7a7853 into master Oct 17, 2023
@JiuqingSong JiuqingSong deleted the u/jisong/standaloneeditorutils branch October 17, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants