Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone editor: Remove dependencies to enums Part 1 #2152

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

JiuqingSong
Copy link
Collaborator

Remove dependencies to existing enums from old code. Some enums can be converted into string literal type, some are used for persist content so we need to keep them for compatibility and convert to regular enum (non-const) instead so that we don't need to general "Compatible*" types any more.

  • EntityOperation: Create a string literal type in roosterjs-content-model-editor package instead
  • BulletListType: Create a new enum (non-const) type in roosterjs-content-model-types package
  • NumberingListType: Create a new enum (non-const) type in roosterjs-content-model-types package
  • TableCellMetadataFormat: Create a copy in roosterjs-content-model-editor package
  • TableBorderFormat: Create a new enum (non-const) type in roosterjs-content-model-types package
  • FormatState: Move the content into ContentModelFormatState type

@JiuqingSong JiuqingSong changed the title Standalone editor: Remove dependencies to enums Standalone editor: Remove dependencies to enums Part 1 Oct 18, 2023
@JiuqingSong JiuqingSong merged commit e55b4d6 into master Oct 18, 2023
7 checks passed
@JiuqingSong JiuqingSong deleted the u/jisong/standaloneeditorenum branch October 18, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants