Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone editor: Remove dependencies to enums Part 2 #2153

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Standalone editor: Remove dependencies to enums Part 2 #2153

merged 3 commits into from
Oct 18, 2023

Conversation

JiuqingSong
Copy link
Collaborator

  • Keys: Use KeyboardEvent.key instead
  • ChangeSource: Create a copy of non-const enum in roosterjs-content-model-editor
  • KnownPasteSourceType: Create a string literal type instead, and copy paste source related code into content model
  • PasteType: Create a string lteral type instead

@JiuqingSong JiuqingSong merged commit 88bdecf into master Oct 18, 2023
7 checks passed
@JiuqingSong JiuqingSong deleted the u/jisong/u/jisong/standaloneeditorenum2 branch October 18, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaroldi juliaroldi juliaroldi approved these changes

@flyingbee2012 flyingbee2012 Awaiting requested review from flyingbee2012

@BryanValverdeU BryanValverdeU Awaiting requested review from BryanValverdeU

@ianeli1 ianeli1 Awaiting requested review from ianeli1

@vinguyen12 vinguyen12 Awaiting requested review from vinguyen12

@Andres-CT98 Andres-CT98 Awaiting requested review from Andres-CT98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiuqingSong @juliaroldi