Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Content Model handle ENTER key #2610

Merged
merged 33 commits into from
Jun 6, 2024
Merged

Conversation

JiuqingSong
Copy link
Collaborator

@JiuqingSong JiuqingSong commented May 1, 2024

This covers the following scenarios:

  1. Enter on normal paragraph, split the paragraph and bring focus to the new line
  2. Enter on list item, split the list item
  3. Enter on empty list item, reduce list level
  4. Enter on empty quote line, unquote this line
  5. Enter on expanded selection, first delete the selected content, then do the action above
  6. Shift+Enter, always split current paragraph

@JiuqingSong JiuqingSong changed the title Let Content Model handle ENTER key Perf step 1: Let Content Model handle ENTER key May 2, 2024
@JiuqingSong
Copy link
Collaborator Author

#2586 #2510

@JiuqingSong JiuqingSong changed the title Perf step 1: Let Content Model handle ENTER key Let Content Model handle ENTER key Jun 5, 2024
@JiuqingSong JiuqingSong marked this pull request as ready for review June 5, 2024 16:51
@juliaroldi juliaroldi self-requested a review June 6, 2024 18:04
@JiuqingSong JiuqingSong merged commit 48855d1 into master Jun 6, 2024
7 checks passed
@JiuqingSong JiuqingSong deleted the u/jisong/keyboardenter branch June 6, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants