Word Desktop LineHeight fix on paste #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3b2f715.
BryanValverdeU
requested review from
flyingbee2012,
JiuqingSong,
ianeli1,
vinguyen12,
juliaroldi and
Andres-CT98
BryanValverdeU
changed the title
…osoft/roosterjs into u/bvalverde/wordDesktopBug1
JiuqingSong
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Word Desktop set the line lineheight as percentages based on the At least property.
For example if in Word you set 1.16 line height after paste the value is going to be 116% in the HTML clipboard.
The problem here is that in Browser the default line height is 1.2/120% (according to https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#normal) so if you set the value as 116% instead of having a bigger line height the line height in the browser is going to look smaller.
So change the way how we parse the line height when pasting from Word Desktop and use the line Height percentage value and multiply it by the Browser default line height.
Word Document used for test:
Before (Notice how the 1.16 line height paragraph look smaller than the 1 paragraph, because of the issue)
After (1.16 now looks with bigger line height than the "1" lineheight paragraph)
