Ensure focusNode exists when selectionChanges #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
requested review from
BryanValverdeU,
JiuqingSong,
ianeli1,
vinguyen12 and
Andres-CT98
JiuqingSong
reviewed
Jun 21, 2024
| @@ -595,7 +595,7 @@ class SelectionPlugin implements PluginWithState<SelectionPluginState> { | |||
| //If am image selection changed to a wider range due a keyboard event, we should update the selection | |||
| const selection = this.editor.getDocument().getSelection(); | |||
|
|
|||
| if (newSelection?.type == 'image' && selection) { | |||
| if (newSelection?.type == 'image' && selection && selection.focusNode) { | |||
| if (selection && !isSingleImageInSelection(selection)) { | |||
There was a problem hiding this comment.
Here we checked "selection" twice, in line 598 and 599. These two lines can be merged
BryanValverdeU
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selectionChange event happens, ensure the focus exist before setting the selection in the new position, otherwise
getRangeSelection(0) will return an error, since nothing is selected.