Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Up and Down in Table #2767

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

BryanValverdeU
Copy link
Contributor

When using Up in the first row or Down in the last row, the result is not expected. This is because right now we default to the default browser behavior.

This PR adds this functionality:

  1. When Up is pressed in the first row, we select the element before the table.
  2. When Down is pressed in the last Row, we select the elemet after the table.
    (open gifs in new tab looks like recording have too many resolution and cursor is not visible)

Before
ArrowKeyb4

After
ArrowKeyNow

@BryanValverdeU BryanValverdeU merged commit 024877f into master Aug 15, 2024
7 checks passed
@juliaroldi juliaroldi mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants