Support ESLint 8.x

[MichaelDeBoey]

ESLint v8.0.0 is released 🎉

It would be awesome to have official ESLint 8 support. 👊
I'm happy to help where I can of course 🙂

[iclanton]

@octogonz - want to take a look at this?

[octogonz]

We don't normally adopt or support beta versions of tools (since it's already a nontrivial time investment to keep up with officially released versions 😇).

I'm fine however if someone wants to make a PR that enables usage of eslint-v8.0.0-beta-*. Heft should probably print a notice to the console saying it's not officially supported.

I'm also curious to see what will happen with @rushstack/eslint-patch.

[lukashass]

ESLint 8.0.0 was just released 😉 https://eslint.org/blog/2021/10/eslint-v8.0.0-released

[anonrig]

Any updates or news from this issue?

[marcoreni]

@iclanton I think this should be reopened since #2965 only solved issues for eslint-patch package.

[D4N14L]

@marcoreni is correct, this should be re-opened. I will take a look at this soon.

[lukashass]

@D4N14L FYI I already started this in #3009. Not sure if that covers everything needed to close this issue. Also, it is blocked by upstream changes as far as I can tell, but feel free to continue.

[D4N14L]

@lukashass yes, I noticed this just recently, sorry for missing that! I already had some additional changes in my branch, so I'll likely create a separate PR for it. I'll tag you when I get that out.

[stefaneg]

I am working on getting eslint to work with heft, having trouble making it work with eslint 8.7.0.

Is it possible that the documentation is out of date here?

https://www.npmjs.com/package/@rushstack/eslint-config

[D4N14L]

@stefaneg it seems like it works successfully (see this PR: #3185). What is the issue you're having?

[stefaneg]

The error I get is this when execute heft build with .eslintrc.js exactly as it specified in the documentation. I have verified that everything is present in node_modules at the correct paths.

> heft build 
Project build folder is "/Users/gulli/src/github.com/rush-example/libraries/logging"
Starting build
 ---- Pre-compile started ----
 ---- Pre-compile finished (1ms) ----
 ---- Compile started ----
[typescript] Using TypeScript version 3.9.10
[eslint] Using ESLint version 8.7.0
 ---- Compile encountered an error (2239ms) ----
-------------------- Finished (2.51s) --------------------
Project: @tm.is/[email protected]
Heft version: 0.44.2
Node version: v16.13.1
Error: Cannot read config file: /Users/gulli/src/github.com/rush-example/libraries/logging/.eslintrc.js
Error: Failed to patch ESLint because the calling module was not recognized

I tried downgrading ESLint to 7.32.0, and the error persists, so the issue seems to be something else.

[stefaneg]

It looks like the message is originating here:

rushstack/eslint/eslint-patch/src/modern-module-resolution.ts

Line 158 in 0177df0

'Failed to patch ESLint because the calling module was not recognized.\n' +

Hard to be sure unless there is an output processor that outputs only the first line of the exception message to stderr.

EDIT:

Turned out that I managed somehow to install an old version of @rushstack/eslint-config which led to those obscure errors.