-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-extractor] Improve analysis of types exposed via global variables #1767
Conversation
…lTable._analyzeChildTree()
…when resolving a .d.ts rollup naming conflict
…nd standardize the way source file paths are reported
05fc1ee
to
2e11017
Compare
workingPackageFolderPath?: string | ||
} | ||
|
||
export class SourceFileLocationFormatter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be cool to genericize this. Maybe add it to the Terminal
API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not a bad idea. API Extractor's usage is coupled to the compiler API, so I think I would approach this work item from some other tool that wants to report file/line information.
Terminal
doesn't seem like the right place, because it's about writing to a terminal. Path
might not be a bad choice, or maybe something more specific like SourceFilePath
. It could possibly also include a generalized equivalent of getLineAndCharacterOfPosition()
.
But again, I'd want to introduce that API as part of solving some problem that actually needs it, so we know what the requirements are.
This fix was published with API Extractor 7.7.12. |
This is an initial prototype of a solution for #1765
Also fixes #1095
Also fixes #1316
Reverts half-baked workaround from #1098
I've also improved
--diagnostics
switch to report when globals are encountered. Example output: