Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not emit progress for single loose object downloads #195

Closed
mjcheetham opened this issue Oct 24, 2019 · 1 comment · Fixed by #196
Closed

Do not emit progress for single loose object downloads #195

mjcheetham opened this issue Oct 24, 2019 · 1 comment · Fixed by #196
Assignees
@derrickstolee
Labels
polish

Comments

@mjcheetham
Copy link
Member

When we need to download multiple, single loose objects, the output is very verbose and not very informative of progress (since we don't know how many more singular loose objects are going to be requested).

We should just drop the progress downloading in gvfs-helper "1 loose object" (unless it starts taking 'a long time').

mattche-mbp-01:src mattche$ git pull
Receiving 1 loose object (bytes received): 100% (375/375), done.
Receiving 1 loose object (bytes received): 100% (350/350), done.
Receiving 1 loose object (bytes received): 100% (224/224), done.
Receiving 1 loose object (bytes received): 100% (276/276), done.
Receiving 1 loose object (bytes received): 100% (779/779), done.
From https://mseng.visualstudio.com/AzureDevOps/_git/AzureDevOps
   edd94f1cf5b9..73d147b4de62  master                            -> origin/master
   cf0e56018c1f..16140c04e5c5  releases/AzureDevOps2019.1public  -> origin/releases/AzureDevOps2019.1public
   eadc257e2d74..a561db193597  releases/M153                     -> origin/releases/M153
   8c58be4ea336..856cebf7a07f  releases/M153.AzureDevOps2019.1.1 -> origin/releases/M153.AzureDevOps2019.1.1
   243c644e8115..941bc59fffaa  releases/M156                     -> origin/releases/M156
   736f57d62072..59c53d2fc0eb  releases/M157                     -> origin/releases/M157
   ac1c2d3c7187..dc9dddaef970  releases/M158                     -> origin/releases/M158
   a3938999cff2..252cece316de  releases/M159                     -> origin/releases/M159
Updating edd94f1cf5b9..73d147b4de62
Receiving 1 loose object (bytes received): 100% (3573/3573), done.
Receiving 1 loose object (bytes received): 100% (474/474), done.
Receiving 1 loose object (bytes received): 100% (586/586), done.
Receiving 1 loose object (bytes received): 100% (4068/4068), done.
Receiving 1 loose object (bytes received): 100% (822/822), done.
Receiving 1 loose object (bytes received): 100% (289/289), done.
Receiving 1 loose object (bytes received): 100% (575/575), done.
Receiving 1 loose object (bytes received): 100% (260/260), done.
Receiving 1 loose object (bytes received): 100% (226/226), done.
Receiving 1 loose object (bytes received): 100% (687/687), done.
Receiving 1 loose object (bytes received): 100% (1163/1163), done.
Receiving 1 loose object (bytes received): 100% (540/540), done.
Receiving 1 loose object (bytes received): 100% (593/593), done.
Receiving 1 loose object (bytes received): 100% (1110/1110), done.
Receiving 1 loose object (bytes received): 100% (750/750), done.
Receiving 1 loose object (bytes received): 100% (983/983), done.
Receiving 1 loose object (bytes received): 100% (1867/1867), done.
Receiving 1 loose object (bytes received): 100% (232/232), done.
Receiving 1 loose object (bytes received): 100% (389/389), done.
Receiving 1 loose object (bytes received): 100% (604/604), done.
Receiving 1 loose object (bytes received): 100% (579/579), done.
Receiving 1 loose object (bytes received): 100% (236/236), done.
Receiving 1 loose object (bytes received): 100% (528/528), done.
Requesting packfile with 1472 objects (bytes sent): 100% (63327/63327), done.
Receiving packfile with 1472 objects (bytes received): 5871954, done.
Indexing objects: 100% (1472/1472), done.
Updating files: 100% (6442/6442), done.
Fast-forward
@derrickstolee derrickstolee self-assigned this Oct 24, 2019
@derrickstolee
Copy link
Contributor

Fix is in microsoft/git#215, and I'll create a PR in Scalar to take the change soon.

@derrickstolee derrickstolee mentioned this issue Oct 24, 2019
Merged
derrickstolee added a commit that referenced this issue Oct 25, 2019
@derrickstolee
Merge pull request #196: Update Git to show less progress in gvfs-helper
9be2785 
Resolves #195.

Includes the following updates to `microsoft/git`:

* microsoft/git#208: gvfs-helper: auto-retry after network errors, resource throttling, split GET and POST semantics.
* microsoft/git#215: gvfs-helper: dramatically reduce progress noise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derrickstolee derrickstolee

Labels
polish
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Git to show less progress in gvfs-helper
2 participants
@derrickstolee @mjcheetham