-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Add unit tests for Bedrock agent integration #10362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit tests for Bedrock agent integration in Semantic Kernel Python. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/semantic-kernel?shareId=XXXX-XXXX-XXXX-XXXX).
markwallace-microsoft
added
the
python
Pull requests for the Python Semantic Kernel
label
Jan 31, 2025
github-actions
bot
changed the title
Add unit tests for Bedrock agent integration
Python: Add unit tests for Bedrock agent integration
Jan 31, 2025
Python Test Coverage Report •
Python Unit Test Overview
|
moonbox3
approved these changes
Feb 4, 2025
alliscode
approved these changes
Feb 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 4, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
### Motivation and Context Add unit tests for Bedrock agent integration in Semantic Kernel Python. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 3. What problem does it solve? 5. What scenario does it contribute to? 7. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Code coverage for Bedrock agent related implementations reached 100% except for the `bedrock_agent.py` file and `bedrock_agent_base.py` file, which are at 82% and 95% respectively. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/semantic-kernel/pull/10362?shareId=f83b0466-6d2b-4639-88c8-23229aa2694c). --------- Co-authored-by: Evan Mattson <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add unit tests for Bedrock agent integration in Semantic Kernel Python.
Description
Code coverage for Bedrock agent related implementations reached 100% except for the
bedrock_agent.py
file andbedrock_agent_base.py
file, which are at 82% and 95% respectively.Contribution Checklist
For more details, open the Copilot Workspace session.