Skip to content

Commit

Permalink
refactors server sent event handling in workbench-app to fix excessiv…
Browse files Browse the repository at this point in the history
…e reconnects; removes old workflows and interact ux (#261)

Elevates handling of SSE to route level component and adds hooks for
adding/removing listeners from any child component without having to
pass through props. Adds more logging as there was a swallowed error
transforming events that was triggering retries even after new design -
going forward, it'll be more obvious if there is an error causing this -
or if there are 400/500 errors coming from the service.

Instead of updating the old workflows & interact UX components, I went
ahead and removed them since they are no longer needed.
  • Loading branch information
bkrabach authored Nov 24, 2024
1 parent de18b92 commit 0dd996f
Show file tree
Hide file tree
Showing 66 changed files with 262 additions and 6,270 deletions.
4 changes: 3 additions & 1 deletion libraries/python/assistant-extensions/.vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,14 @@
"**/__pycache__": true
},
"cSpell.words": [
"asyncio",
"deepmerge",
"DMAIC",
"endregion",
"Excalidraw",
"openai",
"pdfplumber",
"pydantic"
"pydantic",
"pytest"
]
}
2 changes: 2 additions & 0 deletions libraries/python/skills/skill-library/.vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,12 @@
"cSpell.words": [
"dotenv",
"httpx",
"metadrive",
"openai",
"pydantic",
"pypdf",
"runtimes",
"subdrive",
"tiktoken"
],
"python.testing.pytestArgs": ["skill_library"],
Expand Down
4 changes: 1 addition & 3 deletions workbench-app/.vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@
"reactflow",
"reduxjs",
"rehype",
"retriable",
"rjsf",
"rootpath",
"selectin",
Expand Down Expand Up @@ -226,9 +227,6 @@
"westus",
"winget",
"workbenchservice",
"workflowdefinition",
"workflowrun",
"workflowuserparticipant",
"YYYYMMDDH"
]
}
1 change: 0 additions & 1 deletion workbench-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
"react-syntax-highlighter": "^15.5.0",
"react-virtualized-auto-sizer": "^1.0.24",
"react-virtuoso": "^4.10.4",
"reactflow": "^11.11.4",
"rehype-raw": "^7.0.0",
"remark-gfm": "^4.0.0",
"streamsaver": "^2.0.6"
Expand Down
Loading

0 comments on commit 0dd996f

Please sign in to comment.