Simplify the example guided-conversation definitions (#165)

Remove redundant resource constraints and update comments to match the code
microsoft · Oct 24, 2024 · 49775dc · 49775dc
1 parent ec08f22
commit 49775dc
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 29 deletions.
diff --git a/...ided-conversation-assistant/assistant/agents/guided_conversation/definitions/er_triage.py b/...ided-conversation-assistant/assistant/agents/guided_conversation/definitions/er_triage.py
@@ -1,6 +1,6 @@
 import json
 
-from guided_conversation.utils.resources import ResourceConstraint, ResourceConstraintMode, ResourceConstraintUnit
+from guided_conversation.utils.resources import ResourceConstraintMode, ResourceConstraintUnit
 from pydantic import BaseModel, Field
 
 from ..definition import GuidedConversationDefinition
@@ -58,7 +58,7 @@ class Artifact(BaseModel):
 """
 
 # Resource Constraints - Defines the constraints like time for the conversation
-resource_constraint = ResourceConstraint(
+resource_constraint = GuidedConversationDefinition.ResourceConstraint(
     quantity=10,
     unit=ResourceConstraintUnit.MINUTES,
     mode=ResourceConstraintMode.MAXIMUM,
@@ -70,9 +70,5 @@ class Artifact(BaseModel):
     rules=rules,
     conversation_flow=conversation_flow,
     context=context,
-    resource_constraint=GuidedConversationDefinition.ResourceConstraint(
-        quantity=10,
-        unit=ResourceConstraintUnit.MINUTES,
-        mode=ResourceConstraintMode.MAXIMUM,
-    ),
+    resource_constraint=resource_constraint,
 )
diff --git a/...ided-conversation-assistant/assistant/agents/guided_conversation/definitions/interview.py b/...ided-conversation-assistant/assistant/agents/guided_conversation/definitions/interview.py
@@ -1,6 +1,6 @@
 import json
 
-from guided_conversation.utils.resources import ResourceConstraint, ResourceConstraintMode, ResourceConstraintUnit
+from guided_conversation.utils.resources import ResourceConstraintMode, ResourceConstraintUnit
 from pydantic import BaseModel, Field
 
 from ..definition import GuidedConversationDefinition
@@ -49,7 +49,7 @@ class Artifact(BaseModel):
 """
 
 # Resource Constraints - Defines time limits for the conversation
-resource_constraint = ResourceConstraint(
+resource_constraint = GuidedConversationDefinition.ResourceConstraint(
     quantity=30,
     unit=ResourceConstraintUnit.MINUTES,
     mode=ResourceConstraintMode.MAXIMUM,
@@ -61,9 +61,5 @@ class Artifact(BaseModel):
     rules=rules,
     conversation_flow=conversation_flow,
     context=context,
-    resource_constraint=GuidedConversationDefinition.ResourceConstraint(
-        quantity=30,
-        unit=ResourceConstraintUnit.MINUTES,
-        mode=ResourceConstraintMode.MAXIMUM,
-    ),
+    resource_constraint=resource_constraint,
 )
diff --git a/...conversation-assistant/assistant/agents/guided_conversation/definitions/patient_intake.py b/...conversation-assistant/assistant/agents/guided_conversation/definitions/patient_intake.py
@@ -1,6 +1,6 @@
 import json
 
-from guided_conversation.utils.resources import ResourceConstraint, ResourceConstraintMode, ResourceConstraintUnit
+from guided_conversation.utils.resources import ResourceConstraintMode, ResourceConstraintUnit
 from pydantic import BaseModel, Field
 
 from ..definition import GuidedConversationDefinition
@@ -53,8 +53,8 @@ class PatientIntakeArtifact(BaseModel):
 
 # Resource Constraints (optional) - This defines the constraints on the conversation such as time or turns.
 # It can also help with pacing the conversation,
-# For example, here we have set an exact time limit of 10 turns which the agent will try to fill.
-resource_constraint = ResourceConstraint(
+# For example, here we have set a time limit of 15 minutes which the agent will try to fill.
+resource_constraint = GuidedConversationDefinition.ResourceConstraint(
     quantity=15,
     unit=ResourceConstraintUnit.MINUTES,
     mode=ResourceConstraintMode.MAXIMUM,
@@ -66,9 +66,5 @@ class PatientIntakeArtifact(BaseModel):
     rules=rules,
     conversation_flow=conversation_flow.strip(),
     context=context.strip(),
-    resource_constraint=GuidedConversationDefinition.ResourceConstraint(
-        quantity=15,
-        unit=ResourceConstraintUnit.MINUTES,
-        mode=ResourceConstraintMode.MAXIMUM,
-    ),
+    resource_constraint=resource_constraint,
 )
diff --git a/...-conversation-assistant/assistant/agents/guided_conversation/definitions/poem_feedback.py b/...-conversation-assistant/assistant/agents/guided_conversation/definitions/poem_feedback.py
@@ -1,6 +1,6 @@
 import json
 
-from guided_conversation.utils.resources import ResourceConstraint, ResourceConstraintMode, ResourceConstraintUnit
+from guided_conversation.utils.resources import ResourceConstraintMode, ResourceConstraintUnit
 from pydantic import BaseModel, Field
 
 from ..definition import GuidedConversationDefinition
@@ -57,7 +57,7 @@ class ArtifactModel(BaseModel):
 # Resource Constraints (optional) - This defines the constraints on the conversation such as time or turns.
 # It can also help with pacing the conversation,
 # For example, here we have set an exact time limit of 10 turns which the agent will try to fill.
-resource_constraint = ResourceConstraint(
+resource_constraint = GuidedConversationDefinition.ResourceConstraint(
     quantity=10,
     unit=ResourceConstraintUnit.TURNS,
     mode=ResourceConstraintMode.EXACT,
@@ -69,9 +69,5 @@ class ArtifactModel(BaseModel):
     rules=rules,
     conversation_flow=conversation_flow.strip(),
     context=context.strip(),
-    resource_constraint=GuidedConversationDefinition.ResourceConstraint(
-        quantity=10,
-        unit=ResourceConstraintUnit.TURNS,
-        mode=ResourceConstraintMode.EXACT,
-    ),
+    resource_constraint=resource_constraint,
 )