Examples bug fixes (#38)

* Don't share config object across agent instances of the same type * Graceful failure in case of empty config files
microsoft · Sep 10, 2024 · f7dae92 · f7dae92
1 parent 4fce6e8
commit f7dae92
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 6 deletions.
diff --git a/assistant-connector/dotnet/WorkbenchConnector/Storage/AgentServiceStorage.cs b/assistant-connector/dotnet/WorkbenchConnector/Storage/AgentServiceStorage.cs
@@ -136,6 +136,8 @@ private async Task<List<T>> GetAllAsync<T>(string prefix, string suffix, Cancell
             if (!filename.EndsWith(suffix, StringComparison.OrdinalIgnoreCase)) { continue; }
 
             var content = await File.ReadAllTextAsync(filePath, cancellationToken).ConfigureAwait(false);
+            if (string.IsNullOrEmpty(content)) { continue; }
+
             result.Add(JsonSerializer.Deserialize<T>(content)!);
         }
 

diff --git a/examples/dotnet-01-echo-bot/MyAgent.cs b/examples/dotnet-01-echo-bot/MyAgent.cs
@@ -38,7 +38,9 @@ public MyAgent(
     {
         this.Id = agentId;
         this.Name = agentName;
-        this.Config = agentConfig ?? new MyAgentConfig();
+
+        // Clone object to avoid config object being shared
+        this.Config = JsonSerializer.Deserialize<MyAgentConfig>(JsonSerializer.Serialize(agentConfig)) ?? new MyAgentConfig();
     }
 
     /// <inheritdoc />

diff --git a/examples/dotnet-02-message-types-demo/MyAgent.cs b/examples/dotnet-02-message-types-demo/MyAgent.cs
@@ -44,10 +44,12 @@ public MyAgent(
             storage,
             loggerFactory?.CreateLogger<MyAgent>() ?? new NullLogger<MyAgent>())
     {
+        this._contentSafety = contentSafety;
         this.Id = agentId;
         this.Name = agentName;
-        this.Config = agentConfig ?? new MyAgentConfig();
-        this._contentSafety = contentSafety;
+
+        // Clone object to avoid config object being shared
+        this.Config = JsonSerializer.Deserialize<MyAgentConfig>(JsonSerializer.Serialize(agentConfig)) ?? new MyAgentConfig();
     }
 
     /// <inheritdoc />

diff --git a/examples/dotnet-03-simple-chatbot/MyAgent.cs b/examples/dotnet-03-simple-chatbot/MyAgent.cs
@@ -52,11 +52,14 @@ public MyAgent(
             storage,
             loggerFactory?.CreateLogger<MyAgent>() ?? new NullLogger<MyAgent>())
     {
-        this.Id = agentId;
-        this.Name = agentName;
-        this.Config = agentConfig ?? new MyAgentConfig();
         this._appConfig = appConfig;
         this._contentSafety = contentSafety;
+
+        this.Id = agentId;
+        this.Name = agentName;
+
+        // Clone object to avoid config object being shared
+        this.Config = JsonSerializer.Deserialize<MyAgentConfig>(JsonSerializer.Serialize(agentConfig)) ?? new MyAgentConfig();
     }
 
     /// <inheritdoc />