Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes attachment extraction errors in chat completion messages #125

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

markwaddle
Copy link
Contributor

To give chat-completion context about why a file does not have content, so it doesn't make something up when asked questions about it.

Additionally:

  • places a lock around attachment processing so two different events (file.created and message.created, for example) don't result in the attachment being processed twice in parallel
  • deletes unused, premature assistant capabilities
  • clears file input on message send, so you can send subsequent messages with the same attachment, which is particularly helpful when testing

To give chat-completion context about why a file does not have content,
so it doesn't make something up when asked questions about it.

Additionally, places a lock around attachment processing so two
different events (file.created and message.created, for example) don't
result in the attachment being processed twice in parallel
So you can send subsequent messages with the same attachment, which is
particularly helpful when testing
@markwaddle markwaddle merged commit 56b4d62 into microsoft:main Oct 16, 2024
11 checks passed
@markwaddle markwaddle deleted the markwaddle/attachment-errors branch October 16, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant