Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive make improvements #142

Merged
merged 9 commits into from
Oct 18, 2024
Merged

Recursive make improvements #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c8171cd
Improvements to recursive make
markwaddle Oct 18, 2024
9ed69d7
Update test to work on windows
markwaddle Oct 18, 2024
39a9478
Improve windows shell aliases
markwaddle Oct 18, 2024
d977d1a
Remove unused pytest dependency
markwaddle Oct 18, 2024
11225e3
Make python test target support windows
markwaddle Oct 18, 2024
37bb1b6
app targets will install before running
markwaddle Oct 18, 2024
8f21a5d
adds recursive make to skills directory
markwaddle Oct 18, 2024
ab286c3
Recursive make support for windows
markwaddle Oct 18, 2024
852d0ae
Fix bugs for linux
markwaddle Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions ...kflows/libraries-assistant-extensions.yml → .github/workflows/libraries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,19 @@
name: assistant-extensions tests
name: libraries tests

on:
pull_request:
branches: ["main"]
paths:
[
"libraries/python/assistant-extensions/**",
".github/workflows/libraries-assistant-extensions.yml",
]
paths: ["libraries/**", ".github/workflows/libraries.yml"]

push:
branches: ["main"]
paths:
[
"libraries/python/assistant-extensions/**",
".github/workflows/libraries-assistant-extensions.yml",
]
paths: ["libraries/**", ".github/workflows/libraries.yml"]

workflow_dispatch:

defaults:
run:
working-directory: libraries/python/assistant-extensions
working-directory: libraries

jobs:
test:
Expand Down
7 changes: 0 additions & 7 deletions assistants/guided-conversation-assistant/uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 0 additions & 36 deletions assistants/prospector-assistant/uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion assistants/skill-assistant/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ dependencies = [

[tool.uv]
package = true
dev-dependencies = ["pytest>=8.3.1", "pytest-asyncio>=0.23.8"]

[tool.uv.sources]
# If you copy this file to your project, you should verify the relative path to the following:
Expand Down
11 changes: 0 additions & 11 deletions assistants/skill-assistant/pytest.ini
View file
Open in desktop

This file was deleted.

94 changes: 0 additions & 94 deletions assistants/skill-assistant/uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions libraries/python/assistant-drive/assistant_drive/tests/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,7 @@ class TestModel(BaseModel):
models = list(drive.read_models(TestModel, "summaries"))
assert len(models) == 2

assert models[0].name == "test1"
assert models[1].name == "test2"
assert sorted([models[0].name, models[1].name]) == ["test1", "test2"]


def test_read_model_non_existent_file(drive) -> None:
Expand Down
1 change: 0 additions & 1 deletion libraries/python/assistant-drive/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ dev-dependencies = [
"pytest>=8.3.1",
"pytest-asyncio>=0.23.8",
"pytest-repeat>=0.9.3",
"ruff>=0.6.4",
"ipykernel>=6.29.5",
]

Expand Down
34 changes: 0 additions & 34 deletions libraries/python/assistant-drive/uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions ...es/python/assistant-extensions/assistant_extensions/attachments/tests/test_attachments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ async def test_get_completion_messages_for_attachments(
),
)
)
mock_conversation_context.id = "conversation_id"
mock_conversation_context.assistant.id = "assistant_id"

mock_conversation_context.get_files.return_value = FileList(
files=[
Expand Down
Loading