Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the example guided-conversation definitions #165

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Simplify the example guided-conversation definitions #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions ...ided-conversation-assistant/assistant/agents/guided_conversation/definitions/er_triage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import json

from guided_conversation.utils.resources import ResourceConstraint, ResourceConstraintMode, ResourceConstraintUnit
from guided_conversation.utils.resources import ResourceConstraintMode, ResourceConstraintUnit
from pydantic import BaseModel, Field

from ..definition import GuidedConversationDefinition
Expand Down Expand Up @@ -58,7 +58,7 @@ class Artifact(BaseModel):
"""

# Resource Constraints - Defines the constraints like time for the conversation
resource_constraint = ResourceConstraint(
resource_constraint = GuidedConversationDefinition.ResourceConstraint(
quantity=10,
unit=ResourceConstraintUnit.MINUTES,
mode=ResourceConstraintMode.MAXIMUM,
Expand All @@ -70,9 +70,5 @@ class Artifact(BaseModel):
rules=rules,
conversation_flow=conversation_flow,
context=context,
resource_constraint=GuidedConversationDefinition.ResourceConstraint(
quantity=10,
unit=ResourceConstraintUnit.MINUTES,
mode=ResourceConstraintMode.MAXIMUM,
),
resource_constraint=resource_constraint,
)
10 changes: 3 additions & 7 deletions ...ided-conversation-assistant/assistant/agents/guided_conversation/definitions/interview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import json

from guided_conversation.utils.resources import ResourceConstraint, ResourceConstraintMode, ResourceConstraintUnit
from guided_conversation.utils.resources import ResourceConstraintMode, ResourceConstraintUnit
from pydantic import BaseModel, Field

from ..definition import GuidedConversationDefinition
Expand Down Expand Up @@ -49,7 +49,7 @@ class Artifact(BaseModel):
"""

# Resource Constraints - Defines time limits for the conversation
resource_constraint = ResourceConstraint(
resource_constraint = GuidedConversationDefinition.ResourceConstraint(
quantity=30,
unit=ResourceConstraintUnit.MINUTES,
mode=ResourceConstraintMode.MAXIMUM,
Expand All @@ -61,9 +61,5 @@ class Artifact(BaseModel):
rules=rules,
conversation_flow=conversation_flow,
context=context,
resource_constraint=GuidedConversationDefinition.ResourceConstraint(
quantity=30,
unit=ResourceConstraintUnit.MINUTES,
mode=ResourceConstraintMode.MAXIMUM,
),
resource_constraint=resource_constraint,
)
12 changes: 4 additions & 8 deletions ...conversation-assistant/assistant/agents/guided_conversation/definitions/patient_intake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import json

from guided_conversation.utils.resources import ResourceConstraint, ResourceConstraintMode, ResourceConstraintUnit
from guided_conversation.utils.resources import ResourceConstraintMode, ResourceConstraintUnit
from pydantic import BaseModel, Field

from ..definition import GuidedConversationDefinition
Expand Down Expand Up @@ -53,8 +53,8 @@ class PatientIntakeArtifact(BaseModel):

# Resource Constraints (optional) - This defines the constraints on the conversation such as time or turns.
# It can also help with pacing the conversation,
# For example, here we have set an exact time limit of 10 turns which the agent will try to fill.
resource_constraint = ResourceConstraint(
# For example, here we have set a time limit of 15 minutes which the agent will try to fill.
resource_constraint = GuidedConversationDefinition.ResourceConstraint(
quantity=15,
unit=ResourceConstraintUnit.MINUTES,
mode=ResourceConstraintMode.MAXIMUM,
Expand All @@ -66,9 +66,5 @@ class PatientIntakeArtifact(BaseModel):
rules=rules,
conversation_flow=conversation_flow.strip(),
context=context.strip(),
resource_constraint=GuidedConversationDefinition.ResourceConstraint(
quantity=15,
unit=ResourceConstraintUnit.MINUTES,
mode=ResourceConstraintMode.MAXIMUM,
),
resource_constraint=resource_constraint,
)
10 changes: 3 additions & 7 deletions ...-conversation-assistant/assistant/agents/guided_conversation/definitions/poem_feedback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import json

from guided_conversation.utils.resources import ResourceConstraint, ResourceConstraintMode, ResourceConstraintUnit
from guided_conversation.utils.resources import ResourceConstraintMode, ResourceConstraintUnit
from pydantic import BaseModel, Field

from ..definition import GuidedConversationDefinition
Expand Down Expand Up @@ -57,7 +57,7 @@ class ArtifactModel(BaseModel):
# Resource Constraints (optional) - This defines the constraints on the conversation such as time or turns.
# It can also help with pacing the conversation,
# For example, here we have set an exact time limit of 10 turns which the agent will try to fill.
resource_constraint = ResourceConstraint(
resource_constraint = GuidedConversationDefinition.ResourceConstraint(
quantity=10,
unit=ResourceConstraintUnit.TURNS,
mode=ResourceConstraintMode.EXACT,
Expand All @@ -69,9 +69,5 @@ class ArtifactModel(BaseModel):
rules=rules,
conversation_flow=conversation_flow.strip(),
context=context.strip(),
resource_constraint=GuidedConversationDefinition.ResourceConstraint(
quantity=10,
unit=ResourceConstraintUnit.TURNS,
mode=ResourceConstraintMode.EXACT,
),
resource_constraint=resource_constraint,
)