Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve folder GUIDs when updating a SLN. #238

Closed
ericstj opened this issue Jul 28, 2021 · 2 comments · Fixed by #248
Closed

Preserve folder GUIDs when updating a SLN. #238

ericstj opened this issue Jul 28, 2021 · 2 comments · Fixed by #248
Assignees
@jeffkl
Labels
feature request New feature or enhancement

Comments

@ericstj
Copy link
Member

ericstj commented Jul 28, 2021

Today when we run SLNGen on projects in dotnet/runtime it creates a ton of churn due to re-GUIDing all the SlnFolders.

For example: dotnet/runtime@a6b9a63#diff-ac5f14aedd275460970bcd5cbb362a41f5cb94bd5e83402eea3fd5c9328eb954R14

It'd be nice if that diff wasn't so noisy. I see that project GUIDs are preserved via

slngen/src/Microsoft.VisualStudio.SlnGen/SlnFile.cs

Line 92 in d261186

/// Gets or sets a <see cref="IReadOnlyDictionary{TKey,TValue}" /> containing any existing project GUIDs to re-use.

It'd be nice if the same could be done for folder Guids.
@ericstj ericstj mentioned this issue Jul 28, 2021
Closed
@jeffkl
Copy link
Collaborator

jeffkl commented Jul 28, 2021

I agree, this should be done so the churn is low. I’ll work on this next week!

@jeffkl jeffkl added the feature request New feature or enhancement label Jul 28, 2021
@jeffkl jeffkl self-assigned this Jul 28, 2021
@ViktorHofer
Copy link
Member

Note to myself: Whenever this is ready, update slngen in dotnet/runtime and re-generate the solution files to inspect the diff.

jeffkl added a commit to jeffkl/SlnGen that referenced this issue Aug 11, 2021
@jeffkl
Preserve folder GUIDs in existing solutions
4e1fd8d 
When regenerating a solution, project GUIDs are preserved but folder GUIDs are not.  This change preserves the folder GUIDs based on their relative paths.

Fixes microsoft#238
@jeffkl jeffkl mentioned this issue Aug 11, 2021
Merged
jeffkl added a commit that referenced this issue Aug 11, 2021
@jeffkl
Preserve folder GUIDs in existing solutions (#248)
d4e6b18 
When regenerating a solution, project GUIDs are preserved but folder GUIDs are not.  This change preserves the folder GUIDs based on their relative paths.

Fixes #238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffkl jeffkl

Labels
feature request New feature or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve folder GUIDs in existing solutions jeffkl/SlnGen
3 participants
@ViktorHofer @ericstj @jeffkl