Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS Visual Studio launch support #492

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

richardsondev
Copy link
Member

Add Visual Studio for Mac launcher support

  1. Refactored the static launcher class to prevent duplication of code with a Mac launcher

  2. Changed the default of --launch to be true for macOS

  3. Validated on both Windows and macOS that Visual Studio is launched gracefully after sln generation

  4. Added some unit tests for the launcher

Copy link
Collaborator

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@jeffkl jeffkl merged commit 061f1f4 into microsoft:main Jun 30, 2023
richardsondev added a commit to richardsondev/slngen that referenced this pull request Oct 3, 2024
For both Windows and macOS, Visual Studio is launched by default. The readme correctly states this but the program help wasn't updated in microsoft#492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants