Always honor ProjectGuid, if provided #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
approved these changes
Oct 9, 2024
snorrk
force-pushed
the
user/snbeck/projectguid
branch
from
df37edd to
77236cf
Compare
|
Pending #616 |
Co-authored-by: Snorri Gislason <[email protected]>
…lnGen into user/snbeck/projectguid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetProjectGuid will always create a new ProjectGuid for SDK-style projects, regardless of whether the project contains a ProjectGuid property or not.
This causes issues in solutions containing both SDK-style C# projects and C++/CLI projects (which are always legacy style), since the creation of a random new ProjectGuid prevents project dependencies from being correctly formed in the solution.
This PR updates GetProjectGuid to honor ProjectGuid properties defined in SDK-style projects, allowing SDK-style projects to contain manually defined ProjectGuid properties that match the Project attribute in ProjectReferences defined in legacy projects.