-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target .NET 10 #631
Target .NET 10 #631
Conversation
@jeffkl, I could use some help. I can build it locally but somehow it stumbles on the CI. |
aadf4de
to
6a0d248
Compare
73548b6
to
2aa1212
Compare
Okay I got everything working except a few tests which are throwing strange errors, almost like a behavioral difference in .NET 10, can you debug them @RussKie ? |
@RussKie never mind, I think I figured it out, new MSBuild has new APIs for parsing solutions 😢 I'll see if I can fix it... |
azure-pipelines-official.yml
Outdated
@@ -11,6 +11,8 @@ variables: | |||
BuildPlatform: 'Any CPU' | |||
MSBuildArgs: '"/Property:Platform=$(BuildPlatform);Configuration=$(BuildConfiguration)" "/BinaryLogger:$(Build.SourcesDirectory)\$(ArtifactsDirectory)\msbuild.binlog"' | |||
SignType: 'Real' | |||
DotNet10InstallArgs: '-channel 10.0 -quality daily' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use a specific early version, otherwise we'll get a repeat of #456 - i.e., a consumer may have an earlier version of .NET 10 installed than a version which was used to build the slngen tool.
azure-pipelines.yml
Outdated
@@ -7,6 +7,7 @@ variables: | |||
BuildPlatform: 'Any CPU' | |||
MSBuildArgs: '"/Property:Platform=$(BuildPlatform);Configuration=$(BuildConfiguration)"' | |||
SignType: 'Test' | |||
DotNet10InstallArgs: '-channel 10.0 -quality daily' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Thank you, @jeffkl! |
6c51d1c
to
36aea0a
Compare
I tested it locally against a dotnet/extensions's .NET 10 branch, and all worked as expected. This is good to merge. |
Thank you for your contribution! |
This change does the following:
TargetDotNet10
, which is set totrue
only in CI by default, so that when building on a machine without .NET 10 you don't get a build error. You can manually install .NET 10 in a developer environment and set that environment variable to build and debug locally.net9.0
reference assembliesruntimeconfig.json
still just points to any .NET 10 runtime so we don't have to worry about always installing the same version.net461
was dropped.