[Bug]: TeamsSsoPrompt never completes due to timeout

[stepro]

Language

C#

Version

latest

Description

Here the timeout value (default 15 minutes) is used to assign an absolute expiration time into the state. Later, it is used to determine if the prompt has timed out. Unfortunately, the initial assignment uses DateTime.Now but the check uses DateTime.UtcNow. This means that anybody who is more than 15 minutes behind UTC will observe that the dialog always times out at this stage.

Reproduction Steps

1. Try to run the 06.auth.teamsSSO.bot in the US, which is 5 or more hours behind UTC. It always silently ends the dialog before handling the token exchange invoke activity.

[singhk97]

This issue does not exist in JS. new Date().getTime() is used in both setting the state.experies property and the check.

Definition:

teams-ai/js/packages/teams-ai/src/authentication/TeamsBotSsoPrompt.ts

Line 105 in 8f0fbbd

state.expires = new Date().getTime() + timeout;

Check:

teams-ai/js/packages/teams-ai/src/authentication/TeamsBotSsoPrompt.ts

Line 136 in 8f0fbbd

const hasTimedOut: boolean = isTimeoutActivityType && new Date().getTime() > state.expires;