Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] Streaming - Sample #1964

Closed
Tracked by #1492
lilyydu opened this issue Aug 29, 2024 · 0 comments · Fixed by #1965
Closed
Tracked by #1492

[JS] Streaming - Sample #1964

lilyydu opened this issue Aug 29, 2024 · 0 comments · Fixed by #1965
Assignees
@lilyydu
Labels
JS Change/fix applies to JS. If all three, use the 'JS & dotnet & Python' label P0 samples work wrt samples

Comments

@lilyydu
Copy link
Collaborator

lilyydu commented Aug 29, 2024

No description provided.

@lilyydu lilyydu mentioned this issue Aug 29, 2024
Closed
@lilyydu lilyydu self-assigned this Aug 29, 2024
@lilyydu lilyydu added P0 samples work wrt samples JS & dotnet & Python Change or fix must apply to all three programming languages JS Change/fix applies to JS. If all three, use the 'JS & dotnet & Python' label and removed JS & dotnet & Python Change or fix must apply to all three programming languages labels Aug 29, 2024
@lilyydu lilyydu mentioned this issue Aug 29, 2024
Merged
1 task
corinagum pushed a commit that referenced this issue Aug 30, 2024
@lilyydu
[JS] feat: Streaming - ChefBot Sample (#1965)
bf7b9b1 
## Linked issues

closes: #1964
pending on: #1940

## Details

Modifies existing ChefBot sample to display streaming.

Requirements:
- use `default` augmentation
- use a model that support streaming
- in index.ts, update `OpenAIModel` declaration to configure `stream:
true`
- in index.ts, set informative message in `ActionPlanner` declaration
via `startStreamingMessage`


## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lilyydu lilyydu

Labels
JS Change/fix applies to JS. If all three, use the 'JS & dotnet & Python' label P0 samples work wrt samples
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[JS] feat: Streaming - ChefBot Sample microsoft/teams-ai
1 participant
@lilyydu