Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] Auth sample - Who bot #890

Closed
Tracked by #847
, #669 ,  #1093
...
singhk97 opened this issue Nov 27, 2023 · 0 comments · Fixed by #911
Closed
Tracked by #847
, #669 ,  #1093
...

[JS] Auth sample - Who bot #890

singhk97 opened this issue Nov 27, 2023 · 0 comments · Fixed by #911
Assignees
@singhk97
Labels
JS Change/fix applies to JS. If all three, use the 'JS & dotnet & Python' label

Comments

@singhk97
Copy link
Collaborator

No description provided.

@singhk97 singhk97 mentioned this issue Nov 27, 2023
Closed
@singhk97 singhk97 added the JS Change/fix applies to JS. If all three, use the 'JS & dotnet & Python' label label Nov 27, 2023
@singhk97 singhk97 self-assigned this Nov 27, 2023
This was referenced Nov 27, 2023
Closed
Closed
Merged
singhk97 added a commit that referenced this issue Nov 29, 2023
@singhk97
[JS] feat: Who bot sample, add user sign in method for end user (#911)
25eeb49 
#### work in progress
- [x] Update the sample to include more graph calls and test it

## Linked issues

closes: #890 #895

#### Change details

- Added Who bot sample
- Added `getTokenOrSignInUser` method in `Application` class. It is
meant to be the single catch-all method to sign a user in and get the
token. If the user is signed in it simply returns the token. If not, it
triggers the sign in flow. Starting the sign in flow will only work if
the incoming activity supports it (ex. `message`,
`messageExtension/fetch`...etc). This method will work in action
handlers as well.

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (we use
[TypeDoc](https://typedoc.org/) to document our code)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes
@aacebo aacebo mentioned this issue Dec 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@singhk97 singhk97

Labels
JS Change/fix applies to JS. If all three, use the 'JS & dotnet & Python' label
Projects
None yet
Milestone
No milestone
1 participant
@singhk97