Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] docs: Added reminder to configure VS Code auto attach for debugging #1169

Closed
wants to merge 2 commits into from

Conversation

xtophs
Copy link
Contributor

@xtophs xtophs commented Jan 15, 2024

Linked issues

#minor

Details

small reminder to configure VSCode auto attach behavior in js/samples/README.md

Attestation Checklist

  • [ X] My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (we use TypeDoc to document our code)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

Additional information

@xtophs xtophs changed the title Added reminder to configure VS Code auto attach for debugging [JS] docs: Added reminder to configure VS Code auto attach for debugging Jan 15, 2024
@@ -90,6 +90,18 @@
"order": 2
},
"stopAll": true
},
{
"name": "Debug Local",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "Debug Local",
"name": "Debug Local in BF Emulator",

Thoughts?

@@ -90,6 +90,18 @@
"order": 2
},
"stopAll": true
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this code belongs in the other PR. If so could you please remove this from this PR. Thanks

@corinagum
Copy link
Collaborator

Closing this PR -- please add these changes to #1170

@corinagum corinagum closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants