[JS] feat: Add enableSso property to toggle SSO in user auth scenarios
#1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhk97
requested review from
a team,
corinagum,
aacebo and
lilyydu
as code owners
corinagum
reviewed
Feb 2, 2024
corinagum
reviewed
Feb 2, 2024
corinagum
requested changes
Feb 2, 2024
js/packages/teams-ai/src/authentication/MessageExtensionAuthenticationBase.ts
Outdated
Show resolved
Hide resolved
js/packages/teams-ai/src/authentication/MessageExtensionAuthenticationBase.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Corina <[email protected]>
…ticationBase.ts Co-authored-by: Corina <[email protected]>
…ticationBase.ts Co-authored-by: Corina <[email protected]>
Co-authored-by: Corina <[email protected]>
… into kavin/enableSSo
corinagum
reviewed
Feb 2, 2024
corinagum
approved these changes
Feb 2, 2024
1 task
singhk97
added a commit
that referenced
this pull request
Feb 7, 2024
#1236) ## Linked issues closes: #1194 #991 ## Details * Corresponding JS PR: #1232 for implementation details. ## Attestation Checklist - [x] My code follows the style guidelines of this project - I have checked for/fixed spelling, linting, and other errors - I have commented my code for clarity - I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient) - My changes generate no new warnings - I have added tests that validates my changes, and provides sufficient test coverage. I have tested with: - Local testing - E2E testing in Teams - New and existing unit tests pass locally with my changes --------- Co-authored-by: Corina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
closes: #1194 #991
Details
Introduced
enableSsoproperty in theOAuthSettingsto toggle SSO inOAuthadaptive card, bot and message extension scenarios.Change details
The authentication feature is broken down into these 3 scenarios, so I had to update these individual implementations for the
enableSsoproperty to work.Bot auth
tokenExchangeResourcein the oauth card. The originalOAuthPromptdidn't allow that so I had to create theOAuthBotPromptto override thebeginDialogmethod andsendOauthCard.Message Extension auth
typetoauthinstead ofsilentAuth. I introduced aisSsoSignInmethod to determine whether to use auth or not. This is because the card creation happens in the ME auth base class, which is used forTeamsSSOauth as well.Adaptive Card auth
tokenExchangeResourcein the card.Attestation Checklist
My code follows the style guidelines of this project
I have checked for/fixed spelling, linting, and other errors
I have commented my code for clarity
I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)
My changes generate no new warnings
I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:
New and existing unit tests pass locally with my changes