Skip to content

Commit

Permalink
remove a todo
Browse files Browse the repository at this point in the history
  • Loading branch information
zadjii-msft committed Mar 31, 2022
1 parent 5be7f76 commit 37adb94
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions src/terminal/adapter/InteractDispatch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,18 @@ bool InteractDispatch::IsVtInputEnabled() const
return _pConApi->IsVtInputEnabled();
}

// Method Description:
// - Plumbs through to ConGetSet::FocusChanged. See that method for details.
// Arguments:
// - focused: if the terminal is now focused
// Return Value:
// - true always.
bool InteractDispatch::FocusChanged(const bool focused) const
{
// * We should assume this is false by default?
// * TODO!: ConPTY should ask for this mode? Yea? Lets make sure that VTE will send that sequence even without other mouse sequences enabled.
// - in the past, this is something we've made opt-in (request cursor, for example. Maybe also the other mouse modes, can't recall)
// * gotta make sure that we can always handle the focus events, even if the client hasn't requested them.
// When we do GH#11682, we should make sure that ConPTY requests this mode
// from the terminal when it starts up, and ConPTY never unsets that flag.
// It should only ever internally disable the events from flowing to the
// client application.
_pConApi->FocusChanged(focused);
return true;
}

1 comment on commit 37adb94

@github-actions

This comment was marked as resolved.

Please sign in to comment.