Skip to content

Commit

Permalink
Modernize VtPipeTerm (#17647)
Browse files Browse the repository at this point in the history
This shortens VtPipeTerm quite a bit, which used to have various debug
flags and modes. I kept the `--out` flag to redirect the output to a
file, but I removed the `--debug` (pipe the output through WSL and
show escape sequences visually) and `--headless` (hide conpty) flags.

I did this, because VtPipeTerm always used the system ConPTY API
but I needed it to use my local OpenConsole. I also wanted it to
use overlapped IO for testing but found that it was too difficult
to refactor make that work.

I also noticed that the project was the only holdout for
`conpty.h` which had to be kept in sync with `winconpty.h`.
  • Loading branch information
lhecker authored Aug 26, 2024
1 parent 1f71568 commit 760daa6
Show file tree
Hide file tree
Showing 10 changed files with 207 additions and 1,200 deletions.
1 change: 1 addition & 0 deletions .github/actions/spelling/allow/apis.txt
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ PALLOC
PATINVERT
PEXPLICIT
PICKFOLDERS
PINPUT
pmr
ptstr
QUERYENDSESSION
Expand Down
1 change: 1 addition & 0 deletions .github/actions/spelling/expect/expect.txt
Original file line number Diff line number Diff line change
Expand Up @@ -913,6 +913,7 @@ Keymapping
keyscan
keystate
keyups
Kickstart
KILLACTIVE
KILLFOCUS
kinda
Expand Down
157 changes: 0 additions & 157 deletions src/inc/conpty.h

This file was deleted.

Loading

0 comments on commit 760daa6

Please sign in to comment.