Bugfix: allow refreshed profile page to be deleted

microsoft · Dec 26, 2020 · dd2f3e5 · dd2f3e5
1 parent 1cadbf4
commit dd2f3e5
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/cascadia/TerminalSettingsEditor/MainPage.cpp b/src/cascadia/TerminalSettingsEditor/MainPage.cpp
@@ -104,13 +104,13 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
         {
             if (const auto tag{ selectedItem.as<MUX::Controls::NavigationViewItem>().Tag() })
             {
-                if (const auto profile{ tag.try_as<Model::Profile>() })
+                if (const auto oldProfile{ tag.try_as<Model::Profile>() })
                 {
                     // check if the profile still exists
-                    if (_settingsClone.FindProfile(profile.Guid()))
+                    if (const auto profile{ _settingsClone.FindProfile(oldProfile.Guid()) })
                     {
                         // Navigate to the page with the given profile
-                        contentFrame().Navigate(xaml_typename<Editor::Profiles>(), winrt::make<ProfilePageNavigationState>(_viewModelForProfile(profile), _settingsClone.GlobalSettings().ColorSchemes(), *this));
+                        _Navigate(_viewModelForProfile(profile));
                         return;
                     }
                 }