Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1px window border of the quake dropdown terminal "leaks" onto horizontally adjacent monitor: #10201

Closed
zadjii-msft opened this issue May 26, 2021 · 2 comments · Fixed by #10676
Closed

1px window border of the quake dropdown terminal "leaks" onto horizontally adjacent monitor: #10201

zadjii-msft opened this issue May 26, 2021 · 2 comments · Fixed by #10676
Assignees
@zadjii-msft
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.11

Comments

@zadjii-msft
Copy link
Member

I noticed a super minor thing when trying this out today: the 1px window border of the quake dropdown terminal "leaks" onto my horizontally adjacent monitor:

image

Obviously this is hard to show on a screenshot, but IRL because of the bezel separating my screens I can clearly see the 1px gray border on the leftmost pixel row of my right monitor.

Originally posted by @jantari in #8888 (comment)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 26, 2021
@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels May 26, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone May 26, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 26, 2021
@zadjii-msft zadjii-msft mentioned this issue May 26, 2021
Open
61 tasks
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 27, 2021
@vefatica vefatica mentioned this issue Jul 12, 2021
Closed
@zadjii-msft zadjii-msft self-assigned this Jul 13, 2021
zadjii-msft added a commit that referenced this issue Jul 15, 2021
@zadjii-msft
fixes #10201
45c6354
@zadjii-msft zadjii-msft mentioned this issue Jul 15, 2021
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 15, 2021
@ghost ghost closed this as completed in #10676 Jul 20, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 20, 2021
ghost pushed a commit that referenced this issue Jul 20, 2021
@zadjii-msft
Prevent the quake window's borders from hanging onto adjacent monitors (
5a5902d 
#10676)

## Summary of the Pull Request

We were making the quake window exactly the width of the monitor it was on, but that didn't account for the 1px of border on either side.		

## References
* megathread: #8888

## PR Checklist
* [x] Closes #10201
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Validation Steps Performed

It happened before, it doesn't anymore.
Rosefield pushed a commit to Rosefield/terminal that referenced this issue Jul 22, 2021
@zadjii-msft @Rosefield
Prevent the quake window's borders from hanging onto adjacent monitors (
be50d53 
microsoft#10676)

## Summary of the Pull Request

We were making the quake window exactly the width of the monitor it was on, but that didn't account for the 1px of border on either side.		

## References
* megathread: microsoft#8888

## PR Checklist
* [x] Closes microsoft#10201
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Validation Steps Performed

It happened before, it doesn't anymore.
DHowett pushed a commit that referenced this issue Aug 25, 2021
@zadjii-msft @DHowett
Prevent the quake window's borders from hanging onto adjacent monitors (
47e6a1a 
#10676)

## Summary of the Pull Request

We were making the quake window exactly the width of the monitor it was on, but that didn't account for the 1px of border on either side.		

## References
* megathread: #8888

## PR Checklist
* [x] Closes #10201
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Validation Steps Performed

It happened before, it doesn't anymore.
@ghost
Copy link

ghost commented Aug 31, 2021

🎉This issue was addressed in #10676, which has now been successfully released as Windows Terminal Preview v1.10.2383.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Aug 31, 2021

🎉This issue was addressed in #10676, which has now been successfully released as Windows Terminal Preview v1.11.2421.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.11
Development

Successfully merging a pull request may close this issue.

Prevent the quake window's borders from hanging onto adjacent monitors microsoft/terminal
2 participants
@DHowett @zadjii-msft