Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quake mode hot-key stops working after a while. Restart of terminal fixes it #10340

Closed
aclinick opened this issue Jun 4, 2021 · 3 comments
Closed

Quake mode hot-key stops working after a while. Restart of terminal fixes it #10340

aclinick opened this issue Jun 4, 2021 · 3 comments
Labels
Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Needs-Tag-Fix Doesn't match tag requirements No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@aclinick
Copy link

aclinick commented Jun 4, 2021

Windows Terminal version (or Windows build number)

1.9.1523.0

Other Software

No response

Steps to reproduce

Run terminal preview. leave it in the background. Go do something else for a while - say 30 mins. Hit Win-` and notice how the quake sweetness has been obliterated (by a BFG perhaps?) Restart terminal and quake goodness is back

Expected Behavior

quake mode all the time....

Actual Behavior

no quake sweetness
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 4, 2021
@zadjii-msft
Copy link
Member

Well, that's definitely not expected. I'm assuming "do something else for 30 minutes" is basically just the same as "something causes the keybinding to stop working". As long as the Terminal is running, the keybinding should work. We never unregister the hotkey (except on a settings reload), so there's no reason that the global hotkey should ever become unbound.

I'm not sure what kind of tracing we could get that would be valuable here. I suppose we could add tracing for when we do get a hotkey message, but that would only really tell us if the hotkey was pressed, but we decided not to open an instance. I'm more worried that this is "we never got the hotkey message".

I'd welcome other input on this topic - as is, I'm not sure how to investigate this further.

@zadjii-msft zadjii-msft added Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jul 6, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Jul 6, 2021
@zadjii-msft zadjii-msft mentioned this issue Jul 6, 2021
Open
61 tasks
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 8, 2021
@zadjii-msft zadjii-msft mentioned this issue Aug 9, 2021
Merged
3 tasks
ghost pushed a commit that referenced this issue Aug 11, 2021
@zadjii-msft
Add logging, test for #10875 (#10907)
9c858cd 
## Summary of the Pull Request

This isn't a fix for #10875, but it is logging that help identify the root cause here. The logging may additionally be helpful for some of the other issues we're seeing elsewhere in the repo, namely #10340. 

@lhecker is actually working on the fix for #10875, so hopefully this test will help validate.

## References
* Regressed in #10666.
* logging for #8888

## PR Checklist
* [x] Closes nothing
* [x] I work here
* [x] Tests added, and they absolutely fail, but they're localtests, so ¯\\\_(ツ)_/¯
* [n/a] Requires documentation to be updated

## details

While I was here, I noticed that `KeyBindingsTests::KeyChords` has been broken for some time now. So I fixed that too.
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@zadjii-msft
Copy link
Member

@aclinick You still seeing this? We haven't really had any other reports of this, so I suspect it was just an intermittent issue on your machine. We might have some logging you can do if it is still happening with relative frequency.

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 2, 2022
@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Feb 6, 2022
@ghost
Copy link

ghost commented Feb 6, 2022

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost ghost closed this as completed Feb 9, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Needs-Tag-Fix Doesn't match tag requirements No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@DHowett @zadjii-msft @aclinick