Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TerminalAppLocalTests::TabTests are failing #12158

Closed
j4james opened this issue Jan 13, 2022 · 2 comments · Fixed by #12997
Closed

TerminalAppLocalTests::TabTests are failing #12158

j4james opened this issue Jan 13, 2022 · 2 comments · Fixed by #12997
Assignees
@zadjii-msft
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.14

Comments

@j4james
Copy link
Collaborator

j4james commented Jan 13, 2022

Windows Terminal version

Commit c3fd26a

Windows build number

10.0.19041.1415

Other Software

No response

Steps to reproduce

  1. Checkout the latest code.
  2. Build.
  3. Run the TerminalAppLocalTests unit tests.

Expected Behavior

Tests should pass.

Actual Behavior

Two tests are failing:

TerminalAppLocalTests::TabTests::TestPreviewCommitScheme [Failed]
TerminalAppLocalTests::TabTests::TestPreviewDismissScheme [Failed]

As far as I can tell, these first stopped working in commit c3fd26a.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 13, 2022
@zadjii-msft
Copy link
Member

That sounds like something I screwed up. Welp. I'll take a look. Thanks CI @j4james!

@zadjii-msft zadjii-msft self-assigned this Jan 13, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.13 milestone Jan 13, 2022
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Jan 13, 2022
@j4james j4james mentioned this issue Jan 13, 2022
Merged
6 tasks
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 8, 2022
@lhecker
Copy link
Member

lhecker commented Mar 11, 2022

3 tests failing for me:

TerminalAppLocalTests::TabTests::VerifyCommandPaletteTabSwitcherOrder [Failed]
TerminalAppLocalTests::TabTests::TestPreviewCommitScheme [Failed]
TerminalAppLocalTests::TabTests::TestPreviewDismissScheme [Failed]

@lhecker lhecker changed the title TestPreviewCommitScheme and TestPreviewDismissScheme failing TerminalAppLocalTests::TabTests are failing Mar 11, 2022
@zadjii-msft zadjii-msft mentioned this issue Apr 28, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Apr 28, 2022
@ghost ghost closed this as completed in #12997 May 5, 2022
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels May 5, 2022
ghost pushed a commit that referenced this issue May 5, 2022
@zadjii-msft
Fix the TabTests, April 2022 edition (#12997)
cd86c0f 
In classic fashion, we never run the LocalTests locally before committing, so stuff breaks from time to time.

This time, the main trick was that the tests had a pretty hardcore dependency on the inner workings of `_PreviewActionHandler`, and when that changed, they broke.

Also, there was a weird crash I saw when I had the default terminal set to the Dev build version. That crash would let the test contents pass, but ultimately fail when TAEF tore down the conhost. Unsetting that fixed the crash 🤷 

Closes #12158
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.14
Development

Successfully merging a pull request may close this issue.

Fix the TabTests, April 2022 edition microsoft/terminal
4 participants
@DHowett @lhecker @j4james @zadjii-msft