Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Scroll from selection dragging out of window #1247

Closed
carlos-zamora opened this issue Jun 13, 2019 · 4 comments · Fixed by #1523
Closed

Feature Request: Scroll from selection dragging out of window #1247

carlos-zamora opened this issue Jun 13, 2019 · 4 comments · Fixed by #1523
Assignees
@carlos-zamora
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@carlos-zamora
Copy link
Member

Summary of the new feature/enhancement

prereq: make sure you can scroll in the instance you're on

  1. begin making a selection
  2. As you move your mouse and expand the selection, move it towards a scrollable part of the buffer (so, up or down)

As of now, the selection "stops" at the end of the window.

The feature is that it should act like regular ConHost instances where it starts scrolling for you so that you can keep expanding the selection.

Proposed technical implementation details (optional)

I'm hoping this isn't too difficult. We would have to detect when the mouse gets close/past the edge of the window. Then, when that actually occurs, communicate with the scrollBar and move it.
@carlos-zamora carlos-zamora added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Jun 13, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 13, 2019
@carlos-zamora carlos-zamora mentioned this issue Jun 13, 2019
Merged
5 tasks
@carlos-zamora carlos-zamora self-assigned this Jun 13, 2019
@DHowett-MSFT DHowett-MSFT removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 13, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Jun 13, 2019
@Summon528
Copy link
Contributor

Is this #1083?

@carlos-zamora
Copy link
Member Author

Is this #1083?

To my understanding, #1083 is more about the selection updating its y-position when the cursor goes off of the right/left side. This one is goes into effect when moving the cursor off of the top/bottom side.

E.g.: If the terminal can be scrolled up, begin making a selection and move the cursor over the top of the terminal. The terminal should start scrolling for you to continue making a selection.

This was referenced Jun 19, 2019
Merged
Closed
@hmiglani-work
Copy link

For impact this also affects the PSReadline CaptureScreen function, which is really useful.

@mcpiroman mcpiroman mentioned this issue Jun 24, 2019
Merged
5 tasks
@DHowett-MSFT DHowett-MSFT mentioned this issue Jul 22, 2019
Closed
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. labels Jul 24, 2019
miniksa pushed a commit that referenced this issue Jul 24, 2019
@mcpiroman @miniksa
Scroll from selection dragging out of window (#1247) (#1523)
5da2ab1 
* Scroll from selection dragging out of window
* Review changes, dynamic dt measurement, function separation
@ghost
Copy link

ghost commented Aug 3, 2019

🎉This issue was addressed in #1523, which has now been successfully released as Windows Terminal Preview v0.3.2142.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Scroll from selection dragging out of window (#1247) mcpiroman/terminal
4 participants
@Summon528 @carlos-zamora @DHowett-MSFT @hmiglani-work