Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md still refers to VS2017 and v14.1 toolchain #1834

Closed
pgerell opened this issue Jul 5, 2019 · 1 comment · Fixed by #1932
Closed

README.md still refers to VS2017 and v14.1 toolchain #1834

pgerell opened this issue Jul 5, 2019 · 1 comment · Fixed by #1932
Assignees
@bitcrazed
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@pgerell
Copy link

pgerell commented Jul 5, 2019 •
edited
Loading

The new requirements to build the project after #1012 are not documented.
I have problems trying to build with VS2019, but want to be sure I have the correct setup before reporting those issues.
@pgerell pgerell added the Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs label Jul 5, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 5, 2019
@carlos-zamora carlos-zamora added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements labels Jul 5, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Jul 8, 2019
@DHowett-MSFT DHowett-MSFT modified the milestones: Terminal v1.0, needs-tr Jul 8, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 8, 2019
@DHowett-MSFT DHowett-MSFT modified the milestones: needs-tr, Terminal v1.0 Jul 8, 2019
@DHowett-MSFT
Copy link
Contributor

@bitcrazed would be more than happy to fix this. Thanks for the catch!

@DHowett-MSFT DHowett-MSFT mentioned this issue Jul 11, 2019
Merged
@ghost ghost added the In-PR This issue has a related PR label Jul 11, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 11, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bitcrazed bitcrazed

Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Update the readme to clear out references to VS2017 microsoft/terminal
5 participants
@bitcrazed @carlos-zamora @DHowett-MSFT @pgerell @zadjii-msft