Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move version to vs2019, the 1903 sdk, and the 14.2 build tools. #1012

Merged
merged 8 commits into from
Jun 26, 2019

Conversation

miniksa
Copy link
Member

@miniksa miniksa commented May 24, 2019

Summary of the Pull Request

Moves the solution to VS2019 and the latest SDK/tools

PR Checklist

Detailed Description of the Pull Request / Additional comments

This is sitting here until we figure out what to do with the build agents regarding versioning and signing.

@miniksa
Copy link
Member Author

miniksa commented May 24, 2019

WELP. Looks like the 2019 hosted pool doesn't have the 1903 SDK yet either...

https://github.com/Microsoft/azure-pipelines-image-generation/blob/master/images/win/Vs2019-Server2019-Readme.md

@miniksa
Copy link
Member Author

miniksa commented May 24, 2019

@InsightfulEthics
Copy link

I ran this locally on my machine after I saw that it failed the pipeline as the pipeline doesn’t have the v142 tool kit and the build was a success! I downloaded the zip from this Archive and set it up just as mentioned in #489 as #565 only worked the first build then failed afterwards. In this attempt I specifically retargeted the build to the 10.0.18362.0 SDK and checked the toolkit to make sure it was targeted to v142 despite knowing it is now predefined in the code. I let it run and it came back with a few warnings that are all common in the other pipeline builds but not of massive concern as the build did succeed. I certainly do hope to see this solution work for others. Keep up the great work!

@miniksa
Copy link
Member Author

miniksa commented May 28, 2019

18362 is coming...

https://github.com/microsoft/azure-pipelines-image-generation/pull/953

@oising
Copy link
Collaborator

oising commented May 28, 2019

If there ever was a pipeline that's in dire need of azure devops build cache save/restore tasks, this one is it. Apparently these things are real, and coming pretty soon.

@miniksa
Copy link
Member Author

miniksa commented May 30, 2019

If there ever was a pipeline that's in dire need of azure devops build cache save/restore tasks, this one is it. Apparently these things are real, and coming pretty soon.

Say what now? Can you provide a link to this? @oising

@andersosthus
Copy link

@miniksa Looks like it's available for testing for internal orgs: microsoft/azure-pipelines-yaml#113

@miniksa
Copy link
Member Author

miniksa commented May 31, 2019

@andersosthus, thanks. We're not operating as an internal org right now, so I'll probably wait on this like the rest of everyone in the public.

@DHowett-MSFT
Copy link
Contributor

I'm going to tee this up again now that all our dependencies have merged.

@DHowett-MSFT
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@illera88
Copy link

illera88 commented Jun 13, 2019

any update on this? What are the next steps to have this merged?

@DHowett-MSFT
Copy link
Contributor

We're waiting on the 18362 SDK to be deployed to the Azure DevOps tenant from which we're running our CI builds.

@DHowett-MSFT
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@miniksa miniksa marked this pull request as ready for review June 25, 2019 19:51
@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 25, 2019
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 25, 2019
@miniksa miniksa merged commit 5dd1f8d into master Jun 26, 2019
@miniksa miniksa deleted the miniksa-vs2019 branch June 26, 2019 21:13
mcpiroman pushed a commit to mcpiroman/terminal that referenced this pull request Jul 2, 2019
…osoft#1012)

* move version to vs2019, the 1903 sdk, and the 14.2 build tools.
mcpiroman pushed a commit to mcpiroman/terminal that referenced this pull request Jul 23, 2019
…osoft#1012)

* move version to vs2019, the 1903 sdk, and the 14.2 build tools.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the solution to VS2019 and v142 toolset
8 participants