Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: Failing Wide Glyph Tests (x86) #2261

Closed
carlos-zamora opened this issue Aug 5, 2019 · 1 comment · Fixed by #2511
Closed

Bug Report: Failing Wide Glyph Tests (x86) #2261

carlos-zamora opened this issue Aug 5, 2019 · 1 comment · Fixed by #2511
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@carlos-zamora
Copy link
Member

Not sure why x86 wide glyph tests are failing in CI. They work fine locally. Need to investigate what's going on here.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 5, 2019
@carlos-zamora carlos-zamora mentioned this issue Aug 5, 2019
Merged
@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 5, 2019
@carlos-zamora carlos-zamora added Area-Build Issues pertaining to the build system, CI, infrastructure, meta and removed Needs-Tag-Fix Doesn't match tag requirements labels Aug 22, 2019
@carlos-zamora carlos-zamora added this to the Terminal v1.0 milestone Aug 22, 2019
@carlos-zamora carlos-zamora mentioned this issue Aug 22, 2019
Merged
7 tasks
@ghost ghost added the In-PR This issue has a related PR label Aug 22, 2019
DHowett-MSFT pushed a commit that referenced this issue Sep 17, 2019
@carlos-zamora @DHowett
Selection Code Cleanup + Double Click Delimiter Runs (#2511)
4217bed 
* Test: out of bounds selection
* Clean up Selection code:
- selectionVerticalOffset
- proper return values (const)
- Break up GetSelectionRects()

* Fix Delimiter Text Runs (#2552)

* Added helper method and some log comments throughout tests

Closes #1327.
Closes #2261.
Closes #2206.
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Sep 17, 2019
@ghost
Copy link

ghost commented Sep 24, 2019

🎉This issue was addressed in #2511, which has now been successfully released as Windows Terminal Preview v0.5.2661.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Selection Code Cleanup and Double Click Delimiter Runs microsoft/terminal
1 participant
@carlos-zamora