Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The globals object should be layered on the root settings object #2906

Closed
zadjii-msft opened this issue Sep 25, 2019 · 1 comment · Fixed by #3031
Closed

The globals object should be layered on the root settings object #2906

zadjii-msft opened this issue Sep 25, 2019 · 1 comment · Fixed by #3031
Assignees
@zadjii-msft
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal-1910

Comments

@zadjii-msft
Copy link
Member

We added the ability for the root to be used as the globals object in #2515. However, if you have a globals object, then the settings in the root will get ignored. That's bad. We should layer them.
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Sep 25, 2019
@zadjii-msft zadjii-msft added this to the Terminal-1910 milestone Sep 25, 2019
@zadjii-msft zadjii-msft self-assigned this Sep 25, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 25, 2019
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 25, 2019
@zadjii-msft
Copy link
Member Author

(yanking triage since @DHowett-MSFT and I just discussed this)

@DHowett-MSFT DHowett-MSFT mentioned this issue Sep 26, 2019
Closed
@zadjii-msft zadjii-msft mentioned this issue Oct 2, 2019
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Oct 2, 2019
zadjii-msft added a commit that referenced this issue Oct 4, 2019
@zadjii-msft
Layer the globals globals on top of the root globals (#3031)

Verified

This commit was signed with the committer’s verified signature.
mikz Michal Cichra
GPG key ID: 8F4BAE64224DE335
Verified
Learn about vigilant mode
0691c21 
## Summary of the Pull Request

Layer the `globals` globals on top of the root globals.

## PR Checklist
* [x] Closes #2906
* [x] I work here
* [x] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments
We added the ability for the root to be used as the globals object in #2515. However, if you have a globals object, then the settings in the root will get ignored. That's bad. We should layer them.
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal-1910
Development

Successfully merging a pull request may close this issue.

Layer the globals globals on top of the root globals microsoft/terminal
1 participant
@zadjii-msft