Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reordering tabs crashes when Terminal is running elevated #3581

Closed
DJackman123 opened this issue Nov 14, 2019 · 7 comments · Fixed by #4874
Closed

Reordering tabs crashes when Terminal is running elevated #3581

DJackman123 opened this issue Nov 14, 2019 · 7 comments · Fixed by #4874
Assignees
@DHowett-MSFT
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news.
Milestone
Terminal v1.0

Comments

@DJackman123
Copy link
Contributor

DJackman123 commented Nov 14, 2019 •
edited
Loading

Environment

Windows build 10.0.18362.0
Windows Terminal version (if applicable): 0.6.3161.0

Steps to reproduce

Launch Terminal as administrator.
Create a couple of tabs.
Try to reorder the tabs via click+drag

Expected behavior

Tabs are reordered

Actual behavior

Terminal crashes
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 14, 2019
@DHowett-MSFT
Copy link
Contributor

Amazing. I bet this is a platform feature.

@DHowett-MSFT
Copy link
Contributor

(related to XAML islands, tearouts, capturing the mouse across elevation boundaries, etc.)

@DHowett-MSFT DHowett-MSFT added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 14, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 14, 2019
@DHowett-MSFT DHowett-MSFT self-assigned this Nov 14, 2019
@DHowett-MSFT
Copy link
Contributor

This is now being tracked as MSFT:24041938.

@DHowett-MSFT DHowett-MSFT removed their assignment Nov 16, 2019
@Alacritous
Copy link

Are you guys trying to heal this bug holistically or something?

@DHowett-MSFT
Copy link
Contributor

You're funny.
If by holistically you mean "by approaching the people on the Windows platform who own drag/drop to let them know that the drag/drop model doesn't support this use case properly" and "getting them to consider this a valuable feature", yes.

@Alacritous
Copy link

So, you're saying it's unequivocally their fault? That's brave of you.

@microsoft microsoft locked as off-topic and limited conversation to collaborators Dec 17, 2019
@miniksa miniksa added this to the Terminal v1.0 milestone Feb 3, 2020
@miniksa miniksa added Priority-1 A description (P1) Severity-Crash Crashes are real bad news. labels Feb 3, 2020
@miniksa
Copy link
Member

miniksa commented Feb 3, 2020

The platform team has said that they are not going to fix it. They want us to detect when running as administrator and disable drag & drop activity.

@miniksa miniksa removed the Tracking-External This bug isn't resolved, but it's following an external workitem. label Feb 3, 2020
DHowett-MSFT pushed a commit that referenced this issue Mar 10, 2020
@DHowett
Prevent tab reordering while elevated
f86bff2 
There's a platform limitation that causes us to crash when we rearrange
tabs. Xaml tries to send a drag visual (to wit: a screenshot) to the
drag hosting process, but that process is running at a different IL than
us.

For now, we're disabling elevated drag.

Fixes #3581
@ghost ghost closed this as completed in #4874 Mar 11, 2020
ghost pushed a commit that referenced this issue Mar 11, 2020
@DHowett
Prevent tab reordering while elevated (#4874)
a80382b 
There's a platform limitation that causes us to crash when we rearrange
tabs. Xaml tries to send a drag visual (to wit: a screenshot) to the
drag hosting process, but that process is running at a different IL than
us.

For now, we're disabling elevated drag.

Fixes #3581
abhijeetviswam pushed a commit to abhijeetviswam/terminal that referenced this issue Mar 12, 2020
@DHowett @abhijeetviswam
Prevent tab reordering while elevated (microsoft#4874)
4746ba5 
There's a platform limitation that causes us to crash when we rearrange
tabs. Xaml tries to send a drag visual (to wit: a screenshot) to the
drag hosting process, but that process is running at a different IL than
us.

For now, we're disabling elevated drag.

Fixes microsoft#3581
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DHowett-MSFT DHowett-MSFT

Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Prevent tab reordering while elevated microsoft/terminal
5 participants
@Alacritous @DHowett-MSFT @miniksa @cinnamon-msft @DJackman123