Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alt+ Enter rendering error #5029

Closed
Po-wei opened this issue Mar 20, 2020 · 4 comments · Fixed by #5046
Closed

Alt+ Enter rendering error #5029

Po-wei opened this issue Mar 20, 2020 · 4 comments · Fixed by #5046
Assignees
@zadjii-msft
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@Po-wei
Copy link

Po-wei commented Mar 20, 2020 •
edited
Loading

Environment

Windows build number: [[Version 10.0.18363.720]]
Windows Terminal version (if applicable):  0.10.761.0

Any other software?

Steps to reproduce

There are two bugs of Alt+Enter behavior.
Text Disappear && Prompt Duplicate
a. open terminal with WSL
b. type: ls -la or do whatever will print content over a page
c. mouse scroll up to the top
d. type Alt+Enter to Fullscreen
e. text outside orignal windows do not render.
d. scroll down to the bottom: type Alt+Enter several times
f. prompt duplicate several times.

I used zsh with the right side Prompt
image

Actual behavior

image

image

Expected behavior

We need to scroll the terminal to force a re-rendering.
image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 20, 2020
@zadjii-msft
Copy link
Member

@Po-wei could you share your profiles.json?

The second screenshot you've shared is certainly very peculiar. It almost looks like the behavior I'd expect from 0.9, but not 0.10. Like the conpty didn't resize to the newly fullscreen'd size. Especially considering the green from the .tooling line doesn't extend to take the full width of the buffer. I'd bet the buffer didn't actually increase in size.

Oh wow actually I just repro'd that immediately. It's almost as if we don't invalidate the screen or something on a resize.

WE almost certainly don't, because we were repainting the entire screen before on a resize, so this wasn't a problem. Yea okay I know what the fix is.

@zadjii-msft zadjii-msft self-assigned this Mar 20, 2020
@zadjii-msft zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Mar 20, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 20, 2020
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Mar 20, 2020
This was referenced Mar 20, 2020
Closed
Merged
@ghost ghost added the In-PR This issue has a related PR label Mar 20, 2020
@Po-wei
Copy link
Author

Po-wei commented Mar 20, 2020

@zadjii-msft
My profile.json of terminal
https://gist.github.com/Po-wei/5512e0a85ea53ad6075a292c2e9bc77f
It is a pretty normal profile.

@zadjii-msft
Copy link
Member

@Po-wei Thanks for sharing that. I originally thought you might be hitting the "a really large history size causes weird behavior on a maximize", but I was able to actually figure this out already. The fix is already in PR :)

@ghost ghost closed this as completed in #5046 Mar 20, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Mar 20, 2020
ghost pushed a commit that referenced this issue Mar 20, 2020
@zadjii-msft
Make sure to InvalidateAll on a resize (#5046)
0f82811 
## Summary of the Pull Request

Seriously just read the code on this one, it's so incredibly obvious what I did wrong

## References

Regressed with #4741 

## PR Checklist
* [x] Closes #5029
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated
@ghost
Copy link

ghost commented Apr 22, 2020

🎉This issue was addressed in #5046, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Make sure to InvalidateAll on a resize microsoft/terminal
2 participants
@Po-wei @zadjii-msft