Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Mouse Vanish (Hide pointer while typing) #5699

Closed
gfody opened this issue May 2, 2020 · 2 comments
Closed

Support Mouse Vanish (Hide pointer while typing) #5699

gfody opened this issue May 2, 2020 · 2 comments
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Comments

@gfody
Copy link

gfody commented May 2, 2020

If the pointer is over the terminal window then hide it on any non-control keydown event, and restore it on the next mousemove event. But only when SystemParametersInfo(SPI_GETMOUSEVANISH) == true.
@gfody gfody added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 2, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 2, 2020
@DHowett-MSFT
Copy link
Contributor

This is an excellent feature request. It might also be tied up with the cursor visibility work in #5028. I’ll mark this one Help Wanted: if you want to work on it, feel free!

@DHowett-MSFT DHowett-MSFT added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 2, 2020
@carlos-zamora carlos-zamora self-assigned this May 12, 2020
@skyline75489 skyline75489 mentioned this issue Aug 29, 2020
Closed
@DHowett DHowett mentioned this issue Nov 4, 2020
Closed
@Don-Vito Don-Vito mentioned this issue Dec 21, 2020
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Dec 21, 2020
@carlos-zamora carlos-zamora removed their assignment Dec 24, 2020
@ghost ghost removed the In-PR This issue has a related PR label Jan 21, 2021
@ghost ghost closed this as completed in 9c4950c Jan 21, 2021
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jan 21, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

🎉This issue was addressed in #8629, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.:tada:

Handy links:

mpela81 pushed a commit to mpela81/terminal that referenced this issue Jan 28, 2021
@Don-Vito @mpela81
Teach terminal to hide mouse while typing (microsoft#8629)
9cc94c0 
## PR Checklist
* [x] Closes microsoft#5699
* [x] CLA signed. 
* [ ] Tests added/passed
* [ ] Documentation updated. 
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. 

## Detailed Description of the Pull Request / Additional comments
* Use SPI_GETMOUSEVANISH setting
* Hide upon CharacterReceived
* Unhide upon PointerMoved, PointerMoved, MouseWheel, LoseFocus
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal Backlog
Development

No branches or pull requests
4 participants
@gfody @carlos-zamora @DHowett-MSFT @zadjii-msft