Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce/Move TerminalApp bridge #7139

Closed
carlos-zamora opened this issue Jul 31, 2020 · 0 comments · Fixed by #7163
Closed

Introduce/Move TerminalApp bridge #7139

carlos-zamora opened this issue Jul 31, 2020 · 0 comments · Fixed by #7163
Assignees
@carlos-zamora
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.3

Comments

@carlos-zamora
Copy link
Member

Description of the new feature/enhancement

Move TerminalSettings::TerminalSettings to TerminalApp::TerminalSettings

See #885 and #6904 for more details.
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels Jul 31, 2020
@carlos-zamora carlos-zamora added this to the Terminal v1.3 milestone Jul 31, 2020
@carlos-zamora carlos-zamora self-assigned this Jul 31, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 31, 2020
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 31, 2020
@DHowett-MSFT DHowett-MSFT mentioned this issue Jul 31, 2020
Closed
4 tasks
@carlos-zamora carlos-zamora mentioned this issue Aug 3, 2020
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Aug 3, 2020
@ghost ghost closed this as completed in #7163 Aug 3, 2020
ghost pushed a commit that referenced this issue Aug 3, 2020
@carlos-zamora
Move TerminalSettings object to TermApp Project (#7163)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
eb8bb09 
Move TerminalSettings object from TerminalSettings project
(Microsoft.Terminal.Settings) to TerminalApp project. `TerminalSettings`
specifically operates as a bridge that exposes any necessary information
to a TerminalControl.

Closes #7139 
Related Epic: #885
Related Spec: #6904

## PR Checklist
* [X] Closes #7139 
* [X] CLA signed
* [X] Tests ~added~/passed (no additional tests necessary)
* [X] ~Documentation updated~
* [X] ~Schema updated~

## Validation Steps Performed
Deployed Windows Terminal and opened a few new tabs.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 3, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.3
Development

Successfully merging a pull request may close this issue.

Move TerminalSettings object to TermApp Project microsoft/terminal
1 participant
@carlos-zamora