Dragging a tab from Visual Studio Code onto Windows Terminal causes it to crash.

[bhelyer]

Environment

Windows build number: Microsoft Windows NT 10.0.19041.0
Windows Terminal version (if applicable): 1.3.2651.0
VS Code: 1.49.2

Steps to reproduce

1. Open Windows terminal (Powershell or Cmd, doesn't seem to matter)
2. Open Visual Studio Code
3. Drag the 'Welcome' tab (or any other) onto Windows Terminal

(Note that this occured because I missed when using VS Code, not because I thought it would do something meaningful.)

Expected behavior

Nothing, or an error to be generated. I don't rightly know what VS Code sends out when you drag a tab, I'm just expecting Windows Terminal not to crash.

Actual behavior

Windows Terminal closes, taking all my tabs with it as punishment for my failure to accurately use a mouse.

[DHowett]

Whoa, that's wild. That's totally unexpected.

[DHowett]

Looks like VSCode generates a malformed clipboard/drop object; we should be more resilient.

The WinRT DataItems API is failing when we ask "give us the files you said were dropped on me" here (2852):

terminal/src/cascadia/TerminalControl/TermControl.cpp

Lines 2850 to 2853 in 4a11497

	if (e.DataView().Contains(StandardDataFormats::StorageItems()))
	{
	auto items = co_await e.DataView().GetStorageItemsAsync();
	if (items.Size() > 0)

[skyline75489]

I can easily reproduce this. And it is easy to fix the crash by simply catching it. But I kinda want it to work and haven't figured out a way to do so.

For reference, both Edge and Firefox handles the tab dropping from VSCode as a file URI (file://something). Surprisely explorer.exe handles it as an actual file and will paste it to the current directory.

A side note: Should we also support ApplicationLInk and WebLink? Then you can drag and drop an URL from browser and it will be pasted into the terminal. I've tested it and it works pretty well.

[ghost]

🎉This issue was addressed in #8461, which has now been successfully released as Windows Terminal v1.5.10271.0.:tada:

Handy links:

• Release Notes
• Store Download

[ghost]

🎉This issue was addressed in #8461, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.:tada:

Handy links:

• Release Notes
• Store Download