Tab close icon is too big

[eoussama]

Environment

Windows build number: 10.0.19042.630
Windows Terminal version (if applicable): 1.4.3243.0

Any other software? No

Steps to reproduce

Right-click on an open tab, notice the close option

Expected behavior

The tab close icon should be the same size as the other icons

Actual behavior

The tab close icon is too large and distracting almost.

[zadjii-msft]

I guess it does feel a bit bigger, even if it is the same size.

/cc @cinnamon-msft who might have some opinions on the matter

[mdtauk]

I think that icon is designed for a fontsize of 10 or 12 rather than 16

[j4james]

I think the size discrepancy may be because that close icon is not typically used in this context, since it's a "chrome" icon. The cancel icon might be a better choice (\xE711), although that's possibly not semantically correct.

And on a similar note, I would have expected the "Rename Tab" menu item to be using the standard rename icon (\xE8AC). Was there a reason for choosing the current icon? It also looks a little out of place to me.

[j4james]

Also, as a point of comparison, have a look at the icon used on the Exit menu in this example from the Windows UI docs.

https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml/images/keyboard-accelerators.png

That's more in line with what I would have expected for our Close Tab menu.

[zadjii-msft]

I would have expected the "Rename Tab" menu item to be using the standard rename icon (\xE8AC). Was there a reason for choosing the current icon? It also looks a little out of place to me.

oh my god there's a rename icon

Yea it should be that one 🤦‍♂️

The cancel icon might be a better choice (\xE711),

Yea that does look like what we should be using. @Hegunumo wanna try that icon instead?

[cinnamon-msft]

Yeah I agree, that close icon is definitely too large. I am curious how the cancel icon will look, and I agree that the rename icon should be used.

[j4james]

Here's what it looks like with the rename icon updated, as well as the cancel icon for the close menu.

And while we're discussing this code, it's also worth mentioning that many of these standard icons can be set using a SymbolIcon rather than a FontIcon. It's a little easier and more readable that way I think. For example:

Controls::SymbolIcon renameTabSymbol;
renameTabSymbol.Symbol(Controls::Symbol::Rename);

instead of

Controls::FontIcon renameTabSymbol;
renameTabSymbol.FontFamily(Media::FontFamily{ L"Segoe MDL2 Assets" });
renameTabSymbol.Glyph(L"\xE932"); // Label

[ghost]

🎉This issue was addressed in #8424, which has now been successfully released as Windows Terminal v1.5.10271.0.:tada:

Handy links:

• Release Notes
• Store Download

[ghost]

🎉This issue was addressed in #8424, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.:tada:

Handy links:

• Release Notes
• Store Download

[ghost]

The Settings context menu still uses the old icon.

Wouldn't it be better to have a single menu for all tabs?

[zadjii-msft]

@gabrielconl good catch - surprised this was only fixed for Terminal tabs and not the TabBase