Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Settings UI Settings #8755

Closed
carlos-zamora opened this issue Jan 12, 2021 · 0 comments · Fixed by #8774
Closed

Missing Settings UI Settings #8755

carlos-zamora opened this issue Jan 12, 2021 · 0 comments · Fixed by #8774
Assignees
@PankajBhojwani
Labels
Area-SettingsUI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.6

Comments

@carlos-zamora
Copy link
Member

carlos-zamora commented Jan 12, 2021 •
edited by cinnamon-msft
Loading

The following settings are missing from the Settings UI:

Setting Required? Reasoning
Anything pixel shader related ❌ These are very advanced settings that require the user to modify the JSON and file structure.
copyFormatting ✔ v1 should just be a checkbox. v2 should allow further customization introduced by #6004
tabSwitcherMode ✔
launchPosition ❌ This setting is by pixel. It also has support for some weird scenarios like ,5, 5,, and , where blank allows the user to fallback to the system-defined value for that coordinate.
nullable colors (i.e. foreground, background, profile.tabColor, etc) ❌ Design needed. How do you choose null? Must work nicely with #8269.
alwaysOnTop ✔ No one will know about this unless it's in the SUI. Should go onto the Startup page.

copyFormatting and tabSwitcherMode are in scope for v1.6. Since they require localization, this should be started sooner than later.

The others merit greater discussion on whether or not we should include them, and if so, what they would look like.
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Area-SettingsUI Anything specific to the SUI labels Jan 12, 2021
@carlos-zamora carlos-zamora added this to the Terminal v1.6 milestone Jan 12, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 12, 2021
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 12, 2021
@PankajBhojwani PankajBhojwani mentioned this issue Jan 13, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Jan 13, 2021
@PankajBhojwani PankajBhojwani self-assigned this Jan 13, 2021
@ghost ghost closed this as completed in #8774 Jan 14, 2021
@ghost ghost removed the In-PR This issue has a related PR label Jan 14, 2021
ghost pushed a commit that referenced this issue Jan 14, 2021
@PankajBhojwani
Add missing settings to the settings UI (#8774)
f7b5ff3 
Adds the tab switcher mode setting and copy format setting to the SUI

Closes #8755
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jan 14, 2021
@carlos-zamora carlos-zamora mentioned this issue Jan 15, 2021
Open
mpela81 pushed a commit to mpela81/terminal that referenced this issue Jan 28, 2021
@PankajBhojwani @mpela81
Add missing settings to the settings UI (microsoft#8774)
650216b 
Adds the tab switcher mode setting and copy format setting to the SUI

Closes microsoft#8755
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-SettingsUI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.6
Development

Successfully merging a pull request may close this issue.

Add missing settings to the settings UI microsoft/terminal
2 participants
@carlos-zamora @PankajBhojwani