Restore OpenConsoleProxyStub's dependency on the CRT to fix QI #13254
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
| supported according to the CRT maintainer. Dynamic linking against the CRT makes the binaries a bit smaller | ||
| than they would otherwise be if the CRT, runtime, and STL were all statically linked in. --> | ||
| <IgnoreSpecificDefaultLibraries>%(IgnoreSpecificDefaultLibraries);libucrt.lib</IgnoreSpecificDefaultLibraries> | ||
| <AdditionalOptions>%(AdditionalOptions) /defaultlib:ucrt.lib</AdditionalOptions> |
There was a problem hiding this comment.
The only symbol we need is memcmp on ARM64. The linker would tell us otherwise right?
As such I believe we only need to link ucrt.lib?
Edit: Seems like this doesn't work on ARM64 again.
There was a problem hiding this comment.
Edit: Seems like this doesn't work on ARM64 again
Wait, in like, a breaking kind of way? Should we hold this PR?
There was a problem hiding this comment.
Ah I think Leonard means his fix doesn't work on ARM64. I've tested this one 😄
There was a problem hiding this comment.
okay just wanted to make sure
ghost
added
Area-DefApp
Issue-Bug
DHowett
changed the title
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Do we need to mark this up for servicing at all or nah? |
|
Nah, this change isn't in any of our releases yet. |
ghost
merged commit 
When #13160 introduced a new interface to the IConsoleHandoff idl, it
changed midl's RPC proxy stub lookup algorithm from a direct GUID
comparison to an unrolled binary search. Now, that would ordinarily not
be a problem...
However, in #11610, we took a shortcut and replaced
memcmp-- usedonly by RPC for GUID comparison -- with a direct GUID-only equality
comparator. This worked totally fine, and ordinarily would not be a
problem...
The unrolled binary search unfortunately relies on memcmp's contract:
it uses memcmp to match against a fully sorted set. Our memcmp only
returned 0 or 1 (equal or not), and it knew nothing about ordering.
When a package that contains a PackagedCOM proxy stub is installed, it
is selected as the primary proxy stub for any interfaces it can proxy.
After all, interfaces are immutable, so it doesn't matter whose proxy
you're using. Now, given that we installed a broken proxy... all
IIDs that got whacked by our memcmp issue broke for every consumer.
To fix it: instead of implementing memcmp ourselves, we're just going to
take a page out of WinAppSDK's book and link this binary using the
"Hybrid CRT" model. It will statically link any parts of the STL it uses
(none) and dynamically link the ucrt (which is guaranteed to be present
on Windows.)
Sure, the binary size goes up from 8k to 24k, but... the cost is never
having to worry about this again.
Closes #13251