Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix block selection linebreaks in conhost #15423

Merged
merged 1 commit into from
May 26, 2023
Merged

Hotfix block selection linebreaks in conhost #15423

merged 1 commit into from
May 26, 2023

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented May 24, 2023

This regressed in a1f42e8 which only made changes to Windows Terminal
but forgot to make equivalent ones in OpenConsole/conhost.
Without this fix, line breaks in block selections are missing if the
line doesn't force a wrap via an explicit newline.

Closes #15153

Validation Steps Performed

  • Run Far or print long lines of text
  • Trigger block selection via Ctrl+M or Edit > Mark
  • Clipboard contains N-1 newlines lines for N selected rows ✅

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels May 24, 2023
DHowett
DHowett approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cool with this, but since openconsole isn't shipping in 1.17 or 1.18 for its UI, it doesn't meet the servicing bar.

QQ: How can this change be the fix for that user's issue with Terminal? I see, they're using openconsole. That's not exactly intended to be supported, it just happens to work ;P

@lhecker
Copy link
Member Author

lhecker commented May 25, 2023

I'm cool with this, but since openconsole isn't shipping in 1.17 or 1.18 for its UI, it doesn't meet the servicing bar.

Eh, I thought since it's basically a one line change, we might as well ship it... But I'm personally a bit impartial about it.

@DHowett DHowett merged commit cd6b083 into main May 26, 2023
@DHowett DHowett deleted the dev/lhecker/15153-conhost-block-selection branch May 26, 2023 19:32
DHowett pushed a commit that referenced this pull request May 26, 2023
@lhecker @DHowett
Hotfix block selection linebreaks in conhost (#15423)
d90c837 
This regressed in a1f42e8 which only made changes to Windows Terminal
but forgot to make equivalent ones in OpenConsole/conhost.
Without this fix, line breaks in block selections are missing if the
line doesn't force a wrap via an explicit newline.

Closes #15153

## Validation Steps Performed
* Run Far or print long lines of text
* Trigger block selection via Ctrl+M or Edit > Mark
* Clipboard contains N-1 newlines lines for N selected rows ✅

(cherry picked from commit cd6b083)
Service-Card-Id: 89338031
Service-Version: 1.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
1.18 Servicing Pipeline
Status: Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selected block is copied as one line into clipboard
3 participants
@lhecker @DHowett @zadjii-msft