Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility: Set-up UIA Tree #1691
Accessibility: Set-up UIA Tree #1691
Changes from 9 commits
2be5ff2
4c6faec
c1ce169
65dc3ff
8290f78
7417a9a
867412a
a815b42
3eb9947
fc1ad7d
a158e61
dd1b503
b6eed7a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why override to just call parent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this because IUIAWindowNeedsIt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup.
BaseWindow
ANDIUiaWindow
both haveGetWindowRect()
andGetWindowHandle()
(BaseWindow
just calls itGetHandle()
). When I remove these from here, I get "ambiguous access of 'GetWindowRect'" inNonClientIslandWindow
(inherits fromIslandWindow
). Is there a C++-ism that you know about to get around this?