-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility: Set-up UIA Tree #1691
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2be5ff2
- Created IWindow as a common interface to IConsoleWindow and BaseWindow
carlos-zamora 4c6faec
ConHost is building again. Wrong ScreenInfoUiaProvider (SIUP) is bein…
carlos-zamora c1ce169
- Replaced IWindow with IConsoleWindow
carlos-zamora 65dc3ff
Fixed rebase onto master
carlos-zamora 8290f78
CODE FORMATTING
carlos-zamora 7417a9a
Accessibility: Finalized Shared UIA Tree Model (#1915)
carlos-zamora 867412a
included some "using Microsoft::Console::Types" to make code prettier
carlos-zamora a815b42
Changed IslandWindow from IConsoleWindow --> IUiaWindow
carlos-zamora 3eb9947
Moar PR changes
carlos-zamora fc1ad7d
PR Changes
carlos-zamora a158e61
code formatting
carlos-zamora dd1b503
remove unneccessary comments
carlos-zamora b6eed7a
I derped on the commit of removing comments
carlos-zamora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why override to just call parent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this because IUIAWindowNeedsIt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup.
BaseWindow
ANDIUiaWindow
both haveGetWindowRect()
andGetWindowHandle()
(BaseWindow
just calls itGetHandle()
). When I remove these from here, I get "ambiguous access of 'GetWindowRect'" inNonClientIslandWindow
(inherits fromIslandWindow
). Is there a C++-ism that you know about to get around this?